Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/chm_serviceonly.c: only allow service users to join #345

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Jun 16, 2022

intended usecase is to allow for channels that are IPC between atheme and a pseudoserver; this may be too niche for upstream

static int
_modinit(void)
{
mymode = cflag_add('X', chm_staff);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placeholder character, please suggest better options

struct Client *source_p = data->client;
struct Channel *chptr = data->chptr;

if((chptr->mode.mode & mymode) && !IsService(source_p)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way a local client can be a service, so the && !IsService(source_p) part could be removed.

This feels weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants