Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add protocol checks for vcf upload using scripts #5153

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

ClayBirkett
Copy link
Member

Add checks for protocol and markers during VCF upload.
These are the same test used in the web based upload

If new markers are loaded into an existing protocol they will not be available for download. The upload should fail if the markers are not defined.

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@ClayBirkett ClayBirkett requested review from isaak and titima15 October 16, 2024 12:20
@lukasmueller lukasmueller merged commit 9b9062b into master Oct 21, 2024
4 checks passed
@lukasmueller lukasmueller deleted the fix-vcf-upload2 branch October 21, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants