Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trial Metadata Upload #5248

Merged
merged 15 commits into from
Jan 10, 2025
Merged

Trial Metadata Upload #5248

merged 15 commits into from
Jan 10, 2025

Conversation

dwaring87
Copy link
Member

@dwaring87 dwaring87 commented Dec 12, 2024

Description

This adds a new upload option to the Manage > Field Trials page for uploading "Trial Metadata". This allows a user to upload new trial-level metadata for existing trials. Supported metadata:

  • new_trial_name
  • breeding_program
  • location
  • year
  • transplanting_date
  • planting_date
  • harvest_date
  • design_type
  • description
  • trial_type
  • plot_width
  • plot_length
  • field_size

To update a trial, a user must be a curator or (a submitter and a member of the breeding program - both the original and new breeding program, if it's being updated).

It also fixes a bug with the refresh trial tree functions. There was often a race condition when hiding the working modal after uploading a new file and showing the working modal when starting the tree refresh. This resulted in the working modal being stuck after the refresh was complete. I added a short (0.5 second) timeout before starting the refresh to help prevent this.

Fixes #5236

Checklist

  • Refactoring only
  • Documentation only
  • Fixture update only
  • Bug fix
    • The relevant issue has been closed.
    • Further work is required.
  • New feature
    • Relevant tests have been created and run.
    • Data was added to the fixture
      • Data was added via a patch in /t/data/fixture/patches/.
    • User-Facing Change
      • The user manual in /docs has been updated.
    • Any new Perl has been documented using perldoc.
    • Any new JavaScript has been documented using JSDoc.
    • Any new legacy JavaScript has been moved from /js to /js/source/legacy.

@dwaring87 dwaring87 changed the title Topic/batch update trials Trial Metadata Upload Dec 13, 2024
Copy link
Contributor

@afpowell afpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukasmueller lukasmueller merged commit 8518f7a into master Jan 10, 2025
@lukasmueller lukasmueller deleted the topic/batch_update_trials branch January 10, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Batch Update Trial Planting / Harvest Dates
4 participants