fixed cls issue caused by ch units, fixed horizontal overflow issues #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
this should fix #565 |
JasonHassold
force-pushed
the
cls-content-wrapper
branch
from
7b4c995 to
18d9b43
Compare
atilafassina
force-pushed
the
cls-content-wrapper
branch
2 times, most recently
from
e5e4734 to
04c4511
Compare
atilafassina
force-pushed
the
cls-content-wrapper
branch
from
04c4511 to
4cd3705
Compare
atilafassina
approved these changes
Apr 9, 2024
atilafassina
added
site improvement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main docs page content was wrapped in
max-w-proseclass which has a value ofmax-width: 65chthechunit is based on the font so it shifts after the font loads. The computed max-width value had been jumping from 578px to 686px during load.The docs were overflowing horizontally on tablet/small laptop screen sizes since there wasn't enough space for the table of contents on the right or the navigation on the left. I made the side nav hide and switch with the mobile nav menu sooner and made some other adjustments to spacing/sizing so there is enough room for the elements.