Skip to content

2 of 2: Update stores.mdx#666

Merged
atilafassina merged 2 commits intosolidjs:mainfrom
klequis:patch-5
May 5, 2024
Merged

2 of 2: Update stores.mdx#666
atilafassina merged 2 commits intosolidjs:mainfrom
klequis:patch-5

Conversation

@klequis
Copy link
Contributor

@klequis klequis commented Apr 8, 2024

Some rewording suggestions. Please just reject them if you don't think they improve anything.

Regarding: "Stores were intentionally designed to manage data structures like objects and arrays but are capable of handling other data types, such as strings and numbers."

  • I don't see the point here of saying what they were originally intended for unless you need to make the point to users who used an earlier version that didn't work well with data other than arrays and objects.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 654ba72
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6637a08ddfb9d20008dcd47e
😎 Deploy Preview https://deploy-preview-666--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

klequis and others added 2 commits May 5, 2024 17:06
Some rewording suggestions. Please just reject them if you don't think they improve anything.

Regarding: "Stores were intentionally designed to manage data structures like objects and arrays but are capable of handling other data types, such as strings and numbers."
- I don't see the point here of saying what they were originally intended for unless you need to make the point to users who used an earlier version that didn't work well with data other than arrays and objects.
Good change

Co-authored-by: Atila Fassina <atilafassina@gmail.com>
@atilafassina atilafassina merged commit f48c3d3 into solidjs:main May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants