Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style rules from eslint #999

Closed

Conversation

amirhhashemi
Copy link
Contributor

@amirhhashemi amirhhashemi commented Jan 2, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description

Style guidelines are enforced by Prettier, so there is no need to use ESLint for that purpose. In some cases, ESLint rules can conflict with Prettier. For example, Prettier formats "\"text\"" to '"text"', which creates an error according to the ESLint rule "quotes": ["error", "double"].

Copy link

stackblitz bot commented Jan 2, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit b703691
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/6776c3e92be41c00081b81b5
😎 Deploy Preview https://deploy-preview-999--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amirhhashemi amirhhashemi mentioned this pull request Jan 2, 2025
2 tasks
@LadyBluenotes
Copy link
Member

Once again, I'm going to close this in favour of someone from the docs team to handle them.

@solidjs solidjs locked as off-topic and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants