fix: add await to middleware response handling (#1588)

* fix middleware wrapper * revert wrapResponseMiddleware to use sendWebResponse * Create heavy-panthers-confess.md --------- Co-authored-by: Ryan Carniato <ryansolid@gmail.com> Co-authored-by: Atila Fassina <atila@fassina.eu> Co-authored-by: Katja Lutz <katywings@users.noreply.github.com>
solidjs · Jan 31, 2025 · df32b0d · df32b0d
1 parent d260b55
commit df32b0d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.changeset/heavy-panthers-confess.md b/.changeset/heavy-panthers-confess.md
@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+Await internal `sendWebResponse` calls for middlewares that return responses.
diff --git a/packages/start/src/middleware/index.tsx b/packages/start/src/middleware/index.tsx
@@ -27,10 +27,8 @@ function wrapRequestMiddleware(onRequest: RequestMiddleware) {
   return async (h3Event: HTTPEvent) => {
     const fetchEvent = getFetchEvent(h3Event);
     const response = await onRequest(fetchEvent);
-    if (!response) {
-      return;
-    } else {
-      sendWebResponse(h3Event, response);
+    if (response) {
+      await sendWebResponse(h3Event, response);
     }
   };
 }
@@ -39,10 +37,8 @@ function wrapResponseMiddleware(onBeforeResponse: ResponseMiddleware) {
   return async (h3Event: HTTPEvent, response: ResponseMiddlewareResponseParam) => {
     const fetchEvent = getFetchEvent(h3Event);
     const mwResponse = await onBeforeResponse(fetchEvent, response);
-    if (!mwResponse) {
-      return;
-    } else {
-      sendWebResponse(h3Event, mwResponse);
+    if (mwResponse) {
+      await sendWebResponse(h3Event, mwResponse);
     }
   };
 }