Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace shikiji with shiki and upgrade graphql #1702

Closed
wants to merge 0 commits into from

Conversation

Eptagone
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • infrastructure changes
  • Other... Please describe:

What is the current behavior?

shikiji is deprecated because is now merge with shiki.
Current graphql has a vulnerability.

What is the new behavior?

Shikiji was replaced by Shiki and graphql was updated

Other information

Copy link

changeset-bot bot commented Dec 23, 2024

⚠️ No Changeset found

Latest commit: 834f30e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@atilafassina
Copy link
Member

Thanks for doing this!

the graphql was actually a ghost dependency that ended up removed and I pushed some adjustments to main so the Typecheck GH Action isn't a blocker anymore.

Are you able to merge main and push an update?
I'm happy to merge this as soon as we fix the conflicts.

@Eptagone
Copy link
Contributor Author

Eptagone commented Jan 11, 2025

Done. I closed this one by accident... 😅 but I created a new pr with the Shiki change in #1710

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants