Skip to content

fix: handle deleted cookies in single flight request#1864

Closed
zhengkyl wants to merge 2 commits intosolidjs:mainfrom
zhengkyl:main
Closed

fix: handle deleted cookies in single flight request#1864
zhengkyl wants to merge 2 commits intosolidjs:mainfrom
zhengkyl:main

Conversation

@zhengkyl
Copy link
Contributor

@zhengkyl zhengkyl commented Mar 21, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

What is the current behavior?

#1863 Right now cookies are not deleted in single flight requests

What is the new behavior?

Cookies are deleted in single flight requests

Other information

cookie-es is added as a explicit dependency, but it's what h3 uses internally.
https://github.com/unjs/h3/blob/main/src/utils/cookie.ts#L69

Here's parseSetCookie for reference. https://github.com/unjs/cookie-es/blob/main/src/set-cookie/parse.ts

@changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 587668c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Mar 21, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 587668c
🔍 Latest deploy log https://app.netlify.com/sites/solid-start-landing-page/deploys/67de12f4f626c20008553517
😎 Deploy Preview https://deploy-preview-1864--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brenelz
Copy link
Contributor

brenelz commented Sep 11, 2025

@zhengkyl can you fix the conflicts?

@atilafassina
Copy link
Member

couldn't push the conflict fixing and the changesets to this one, so merged the commits to #1970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: Cannot delete cookies during single flight request

3 participants