fix: handle deleted cookies in single flight request#1864
Closed
zhengkyl wants to merge 2 commits intosolidjs:mainfrom
Closed
fix: handle deleted cookies in single flight request#1864zhengkyl wants to merge 2 commits intosolidjs:mainfrom
zhengkyl wants to merge 2 commits intosolidjs:mainfrom
Conversation
|
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
brenelz
reviewed
Jul 12, 2025
brenelz
approved these changes
Sep 10, 2025
Contributor
|
@zhengkyl can you fix the conflicts? |
Member
|
couldn't push the conflict fixing and the changesets to this one, so merged the commits to #1970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
#1863 Right now cookies are not deleted in single flight requests
What is the new behavior?
Cookies are deleted in single flight requests
Other information
cookie-esis added as a explicit dependency, but it's whath3uses internally.https://github.com/unjs/h3/blob/main/src/utils/cookie.ts#L69
Here's
parseSetCookiefor reference. https://github.com/unjs/cookie-es/blob/main/src/set-cookie/parse.ts