fix: fetchEvent -> HeaderProxy checks for null instead of undefined#1919
Merged
atilafassina merged 2 commits intosolidjs:mainfrom Aug 28, 2025
huseeiin:fix-header-proxy
Merged
fix: fetchEvent -> HeaderProxy checks for null instead of undefined#1919atilafassina merged 2 commits intosolidjs:mainfrom huseeiin:fix-header-proxy
fetchEvent -> HeaderProxy checks for null instead of undefined#1919atilafassina merged 2 commits intosolidjs:mainfrom
huseeiin:fix-header-proxy
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
More templates
commit: |
brenelz
reviewed
Jul 12, 2025
null instad of undefinednull instead of undefined
null instead of undefinedfetchEvent.has() checks for null instead of undefined
atilafassina
approved these changes
Aug 28, 2025
fetchEvent.has() checks for null instead of undefinedfetchEvent -> HeaderProxy checks for null instead of undefined
🦋 Changeset detectedLatest commit: 5d5c872 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
event.response.headers.has("does-not-exist")returnstrueWhat is the new behavior?
event.response.headers.has("does-not-exist")returnsfalseOther information