Skip to content

fix: fetchEvent -> HeaderProxy checks for null instead of undefined#1919

Merged
atilafassina merged 2 commits intosolidjs:mainfrom
huseeiin:fix-header-proxy
Aug 28, 2025
Merged

fix: fetchEvent -> HeaderProxy checks for null instead of undefined#1919
atilafassina merged 2 commits intosolidjs:mainfrom
huseeiin:fix-header-proxy

Conversation

@huseeiin
Copy link
Contributor

@huseeiin huseeiin commented Jul 10, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Addresses an existing open issue: fixes #000
  • Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

event.response.headers.has("does-not-exist") returns true

What is the new behavior?

event.response.headers.has("does-not-exist") returns false

Other information

@netlify
Copy link

netlify bot commented Jul 10, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit 5d5c872
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/68b0cf65c2b1f4000987eba8
😎 Deploy Preview https://deploy-preview-1919--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@huseeiin huseeiin changed the title fix: check for null instad of undefined fix: check for null instead of undefined Aug 8, 2025
@huseeiin huseeiin closed this Aug 8, 2025
@huseeiin huseeiin reopened this Aug 16, 2025
@atilafassina atilafassina changed the title fix: check for null instead of undefined fix: fetchEvent.has() checks for null instead of undefined Aug 28, 2025
@atilafassina atilafassina changed the title fix: fetchEvent.has() checks for null instead of undefined fix: fetchEvent -> HeaderProxy checks for null instead of undefined Aug 28, 2025
Copy link
Member

@atilafassina atilafassina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!! 🏆

@changeset-bot
Copy link

changeset-bot bot commented Aug 28, 2025

🦋 Changeset detected

Latest commit: 5d5c872

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solidjs/start Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@atilafassina atilafassina enabled auto-merge (squash) August 28, 2025 21:51
@atilafassina atilafassina merged commit 7282ef4 into solidjs:main Aug 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants