Fix Cloudflare preset not generating functioning applications

[dario-piotrowicz]

PR Checklist

Please check if your PR fulfills the following requirements:

• Addresses an existing open issue: fixes [Bug?]: nitroV2Plugin doesn't generate a valid output with Cloudflare presets #2115
• Tests for the changes have been added (for bug fixes / features)
  👆 No, I don't think that there are tests for the plugin package, if I'm wrong and some tests should be added please do let me know 🙂

What is the current behavior?

Setting up a Cloudflare preset in the plugin's configuration object results in builds not producing a functioning result (see #2115)

What is the new behavior?

A Cloudflare preset can be passed to the plugin's configuration object and builds do produce functioning applications.

Other information

To manually test the changes, create a solid start app via npm create solid, apply one of the cloudflare presets, run npm run build follows by the wrangler dev command that the build command presents in its output and see that the resulting application does not render. Try again but using this PRs pkg-pr-new and see that now it works as intended.

Note: I only tested the changes with cloudflare-module since, as far as I know, it's the generally preferred preset for Cloudflare deployments

[netlify]

✅ Deploy Preview for solid-start-landing-page ready!

Name	Link
🔨 Latest commit	ffdccd5
🔍 Latest deploy log	https://app.netlify.com/projects/solid-start-landing-page/deploys/69bbf95e02f3540008d22e3b
😎 Deploy Preview	https://deploy-preview-2116--solid-start-landing-page.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[changeset-bot]

🦋 Changeset detected

Latest commit: ffdccd5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2116

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2116

commit: ffdccd5

[themavik]

Reviewed the changes — the implementation looks correct and addresses the issue well.

[themavik]

What this PR does: Fixes Cloudflare preset builds by reconstructing full URLs from headers and using a custom virtual entry instead of fromWebHandler, which fails when Nitro strips URLs to path-only.

Done well: The getCloudflareVirtualEntryContent correctly rebuilds the URL from host, x-forwarded-proto, and path. The getHeader helper handles both Headers-like and plain object header formats. Setting noExternals for Cloudflare presets avoids conditional export resolution issues. Good separation in cloudflare.ts.

Edge case: The path construction uses event.path || event.req.url - consider x-forwarded-host for proxied setups.

[brenelz]

Is it possible to add tests for this? Not sure how feasible with it being so tied to cloudflare

[brenelz]

Im told this will break some other adapters

[atilafassina]

Im told this will break some other adapters

can you please elaborate, @brenelz / @huseeiin ?
changes seem scoped to Cloudflare presets to me

[huseeiin]

can you please elaborate, @brenelz / @huseeiin ? changes seem scoped to Cloudflare presets to me

i said it will break netlify i was wrong it will break #2056 because noExternals: isCloudflarePreset(preset) will make noExternals only true if using cloudflare

[dario-piotrowicz]

Is it possible to add tests for this? Not sure how feasible with it being so tied to cloudflare

I asked the same in the PR's description 🙂

I think that the logic of the plugin is not currently being tested and having full e2e/integration tests for this could be a bit involved 🤔

But If we wanted to, I think we could somewhat easily have some unit tests to ensure that the various functions return the expected values

Would you like me to give that a go and actually set up tests for the package here?