dev: Add afterRegisterGraph hook replacing afterCreateSignal#2396
Merged
ryansolid merged 2 commits intosolidjs:mainfrom Feb 21, 2025
Merged
dev: Add afterRegisterGraph hook replacing afterCreateSignal#2396ryansolid merged 2 commits intosolidjs:mainfrom
ryansolid merged 2 commits intosolidjs:mainfrom
Conversation
Deprecate afterCreateSignal for now
🦋 Changeset detectedLatest commit: ff874d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Pull Request Test Coverage Report for Build 13463502559Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
afterRegisterGraphhook allows for both signals, stores and any other custom value registered withDEV.registerGraphto be captured by the devtools when they are created, and even if created outside of a reactive graph - unowned.This also makes the
afterCreateSignalhook, that I added before, pointless so I deprecated it. My bad for not thinking about this before.