-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move authentication method configuration to sidebar settings. #132
base: master
Are you sure you want to change the base?
Move authentication method configuration to sidebar settings. #132
Conversation
96c7c03
to
8053931
Compare
@kennyadsl please Review PR with some Last minor changes to social. Tests fail only on sqlite. |
@rahulsingh321 can you please post some screenshots of the visual part of the change? |
@kennyadsl I added the screenshots of the view now, please have a look when you get chance. |
Am I right that we are using the legacy/classic admin style in the new admin namespace? Any reason why not using the new style (the one with tailwind)? |
@kennyadsl Just to provide support for legacy front-end, I didn't use the tailwind UI. If we don't need that, let me know, I can update that. |
@kennyadsl I would avoid the line break and call it oauth login if that's ok. |
I'd go with Social Auth or Social Login |
@rahulsingh321 please rename the settings menu label to |
@kennyadsl can we fix new admin in a later release given that it's not a setting that you set every day? |
@rahulsingh321 tests still failing |
e4ed0d4
to
3247c36
Compare
@kennyadsl tests are fixed and changes implemented. Ruby 3.0 sqlite is tested, I already raised the question to Jared. Do we still want to test for that? |
3247c36
to
0d25953
Compare
Issue: #131
Listing view:
![Screenshot from 2025-02-04 02-19-52](https://private-user-images.githubusercontent.com/22743359/409289422-28928f5a-e362-46a1-a08f-b801a8cf94fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTM2MjMsIm5iZiI6MTczOTE5MzMyMywicGF0aCI6Ii8yMjc0MzM1OS80MDkyODk0MjItMjg5MjhmNWEtZTM2Mi00NmExLWEwOGYtYjgwMWE4Y2Y5NGZjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzMTUyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzOGMxOWQ5ZDEzMmQzNWM0ZWM0ZTJjODU1NDFkZTIyZTA4ODU1MThkYmY5OTZkZGE2Mjg0NDZiYWFlODY1MDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.Od1Uj3VgvJe9ekIV1rFU0-wRhlhu_osHk1pqycUtGww)
Edit View
![Screenshot from 2025-02-04 02-45-38](https://private-user-images.githubusercontent.com/22743359/409290062-d640e3ce-6d07-4a53-b4ac-f66fe53169d7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxOTM2MjMsIm5iZiI6MTczOTE5MzMyMywicGF0aCI6Ii8yMjc0MzM1OS80MDkyOTAwNjItZDY0MGUzY2UtNmQwNy00YTUzLWI0YWMtZjY2ZmU1MzE2OWQ3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEzMTUyM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBmMjE5M2VmOGVhNzRkMzM2MjBjZWExZmQ4NDAxMDkyMDYzMDkyZWE2OGZkNTg0YWE1NGNjYTExMWU0M2U5ODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.37PxgwI_wGikoz8P5f85DoSv3-eb7-3vMGqDuY8TXrc)