-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention dual-admin transitory period in the backend customisation guide #141
base: main
Are you sure you want to change the base?
Mention dual-admin transitory period in the backend customisation guide #141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespace not correctly capitalized, but otherwise this seems fine.
1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin` | ||
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin` | ||
|
||
SolidusAdmin routes have preference over Spree::admin if the following conditions are met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SolidusAdmin routes have preference over Spree::admin if the following conditions are met: | |
SolidusAdmin routes have preference over Spree::Admin if the following conditions are met: |
1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin` | ||
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin` | ||
|
||
SolidusAdmin routes have preference over Spree::admin if the following conditions are met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin` | ||
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin` | ||
|
||
SolidusAdmin routes have preference over Spree::admin if the following conditions are met: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
@debreczeni Can you give a look to the modifications requested? I think you doc updated is important and it should be considered doing the same with promotions. If you can't find the time I'd be happy to do it :) |
@elia this also |
4d1ef25
to
09a49f7
Compare
Updated it, thanks. |
09a49f7
to
9a0aa8e
Compare
@elia ready and in need of some merging love! |
Summary
Added clarification regarding the parallel admin engine situation to help new developers with onboarding.
Checklist