Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention dual-admin transitory period in the backend customisation guide #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

debreczeni
Copy link

Summary

Added clarification regarding the parallel admin engine situation to help new developers with onboarding.

Checklist

  • I have followed the Diátaxis framework in my PR.
  • I have verified that the preview environment works correctly.

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace not correctly capitalized, but otherwise this seems fine.

1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin`
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin`

SolidusAdmin routes have preference over Spree::admin if the following conditions are met:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SolidusAdmin routes have preference over Spree::admin if the following conditions are met:
SolidusAdmin routes have preference over Spree::Admin if the following conditions are met:

1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin`
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin`

SolidusAdmin routes have preference over Spree::admin if the following conditions are met:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

1. `solidus_backend` as required by default from the `solidus` gem, under the namespace `Spree::Admin`
2. `solidus_admin` as installed by default for new stores since solidus v4.3 and uses the namespace `SolidusAdmin`

SolidusAdmin routes have preference over Spree::admin if the following conditions are met:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@fthobe
Copy link
Contributor

fthobe commented Feb 7, 2025

@debreczeni Can you give a look to the modifications requested? I think you doc updated is important and it should be considered doing the same with promotions. If you can't find the time I'd be happy to do it :)

@fthobe
Copy link
Contributor

fthobe commented Feb 7, 2025

@elia this also

@debreczeni debreczeni force-pushed the clarify-backend-views-override branch from 4d1ef25 to 09a49f7 Compare February 8, 2025 12:01
@debreczeni
Copy link
Author

@debreczeni Can you give a look to the modifications requested? I think you doc updated is important and it should be considered doing the same with promotions. If you can't find the time I'd be happy to do it :)

Updated it, thanks.

@debreczeni debreczeni force-pushed the clarify-backend-views-override branch from 09a49f7 to 9a0aa8e Compare February 8, 2025 12:03
@fthobe
Copy link
Contributor

fthobe commented Feb 8, 2025

@elia ready and in need of some merging love!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants