Allows Rails 8, updates sqlite in Gemfile to match what CI runs#6091
Merged
kennyadsl merged 1 commit intosolidusio:mainfrom Feb 4, 2025
Merged
Allows Rails 8, updates sqlite in Gemfile to match what CI runs#6091kennyadsl merged 1 commit intosolidusio:mainfrom
kennyadsl merged 1 commit intosolidusio:mainfrom
Conversation
github-actions
bot
added
the
changelog:solidus_core
rjacoby
commented
Jan 28, 2025
github-actions
bot
added
the
changelog:solidus_api
rjacoby
commented
Jan 28, 2025
rjacoby
commented
Jan 28, 2025
Contributor
Author
|
@tvdeyen I've got all the tests passing locally, on all 3 databases. Seems like test flake on that one circle run, but I don't have perms to rerun it. |
Contributor
Author
|
@kennyadsl Updated with your suggestion. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6091 +/- ##
==========================================
- Coverage 92.42% 88.70% -3.73%
==========================================
Files 389 829 +440
Lines 8005 17992 +9987
==========================================
+ Hits 7399 15959 +8560
- Misses 606 2033 +1427 ☔ View full report in Codecov by Sentry. |
tvdeyen
reviewed
Jan 31, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. Very much appreciated. Would you mind to rebase with main (and not merge) and squash the fixup into the introducing commit?
Member
|
@rjacoby Rubocop needs your attention as well 🙏🏻 |
Contributor
|
OMG, this is happening much sooner than expected. Thank you so much guys. |
Only send content to tags that support it per Rails 8 deprecations. See: https://github.com/rails/rails/blob/8-0-stable/actionview/CHANGELOG.md#rails-800rc1-october-19-2024 Handle Rails 8 syntax additions to the error text.
Contributor
Author
|
@tvdeyen Rebased, but now the project's codecov isn't happy... |
Contributor
Author
|
@tvdeyen @kushp @kennyadsl Is there anything else keeping it from merging? The codecov seems not related...? |
rahulsingh321
pushed a commit
to rahulsingh321/solidus
that referenced
this pull request
Feb 6, 2025
chaimann
added a commit
to chaimann/solidus
that referenced
this pull request
Feb 13, 2025
A small improvement on changes from solidusio#6091 where calling `tag.method(@tag).parameters.any? { |_type, name| name == :content }` would always return false when @tag == :select, since `tag.select` method's signature has only `*` (:rest) as its parameter, thus not passing any `<option>`s for select tag. Instead, use explicit void elements list to understand whether given element accepts `content`. Somehow the problem is not being flagged by CI builds, but admin specs fail locally.
4 tasks
chaimann
added a commit
to chaimann/solidus
that referenced
this pull request
Feb 13, 2025
A small improvement on changes from solidusio#6091 where in Rails 7 calling `tag.method(@tag).parameters.any? { |_type, name| name == :content }` would always return false when @tag == :select, since `tag.select` method's signature has only `*` (:rest) as its parameter, thus not passing any `<option>`s for select tag. Somehow the problem was not being flagged by CI builds, but admin specs failed locally. Instead, use explicit void elements list to understand whether given element is void, therefore does not accept `content`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
Gemfileandsolidus_core.gemspecup to support Rails 8.0. Makes minor changes to update code and tests to deal with Rails 8 changes.This required bumping
sqlite3above 2.0 to get specs to pass; note that the circleci config already required this and was not testing Rails 7.0 for sqlite likely due to this compatibility mismatch.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: