Respect Spree.user_class' table name in metadata migration#6157
Merged
tvdeyen merged 1 commit intosolidusio:mainfrom Feb 24, 2025
Merged
Respect Spree.user_class' table name in metadata migration#6157tvdeyen merged 1 commit intosolidusio:mainfrom
tvdeyen merged 1 commit intosolidusio:mainfrom
Conversation
Contributor
|
Did we miss that? |
A Spree.user_class might have a different table_name than spree_users. In order to support this we need to ask the class for it's table_name.
5177ad9 to
1bcdfe4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6157 +/- ##
==========================================
+ Coverage 86.64% 88.81% +2.16%
==========================================
Files 514 835 +321
Lines 11891 18152 +6261
==========================================
+ Hits 10303 16121 +5818
- Misses 1588 2031 +443 ☔ View full report in Codecov by Sentry. |
Member
Author
Yap |
kennyadsl
approved these changes
Feb 24, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
Spree.user_classmight have a differenttable_namethanspree_users. In order to support this we need to ask the class for it'stable_name.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: