Revert "Utilize Devise location helpers for redirecting" #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennyadsl
approved these changes
Sep 30, 2022
kennyadsl
deleted the
revert-228-connorferguson/sol-306-deprecate-redirect_back_or_default
branch
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jan 16, 2023
We deprecated `#redirect_back_or_default` method in solidusio#4533 [1]. However, the original plan was halted because of auth problems in solidus_auth_devise. See solidusio/solidus_auth_devise/232 for details. [1] - solidusio#4533 [2] - solidusio/solidus_auth_devise#232
waiting-for-dev
added a commit
to nebulab/solidus
that referenced
this pull request
Jan 16, 2023
We deprecated `#redirect_back_or_default` method in solidusio#4533 [1]. However, the original plan was halted because of auth problems in solidus_auth_devise. See solidusio/solidus_auth_devise/232 [2] for details. [1] - solidusio#4533 [2] - solidusio/solidus_auth_devise#232
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #228
This is causing trouble, and being released in 2.5.5 is preventing admin authentication on new apps using solidus_starter_frontend. The revert will be reinstated on master aiming at the next minor or major release, fixed and with proper documentation on how to upgrade.
cc @cpfergus1
For context: