Handle checkout process for orders fully covered by store credits #348
Conversation
| @@ -3,60 +3,63 @@ | |||
| <legend> | |||
| <%= t('spree.payment_information') %> | |||
| </legend> | |||
| <% if @order.covered_by_store_credit? %> | |||
| <p>Your order is fully covered by store credits, no additional payment method is required.</p> | |||
There was a problem hiding this comment.
This message needs to be associated with a translation key.
There was a problem hiding this comment.
There was a problem hiding this comment.
as pointed out by @kennyadsl in solidusio/solidus#5208 we can start storing frontend related keys in the starter itself, with time we should end up with a tighter, more coherent list of translations for the core instead of the giant ball of unused ones we currently have.
There was a problem hiding this comment.
True. Still, I'd like to keep that change separate from this PR. This change will end up in the starter fronted 4.2 so I think the current approach of adding the translation key to the core is safe because Solidus Starter Frontend 4.2 will only be installed on Solidus 4.2.
I think we can go as Rainer suggested and open an issue for moving the translation keys from the core over here (I expect the usual backward compatibility pain 😅 ).
There was a problem hiding this comment.
@kennyadsl I think there are ways in which it can be less painful, e.g.:
- move all the deprecated translations in core to a separate locale files (e.g.
solidus/core/config/locales/en.deprecated.yml) - copy the file to the host application as part of the solidus installation/upgrade process
- remove the deprecated file in the next major
There was a problem hiding this comment.
Here is the dedicated issue for the mentioned changes: Migrate frontend translations from solidus_core to solidus_starter_frontend #5212
A huge thanks to everyone ❤️
rainerdema
force-pushed
the
nebulab/rainerd/add-message-if-order-is-fully-covered-by-store-credits
branch
2 times, most recently
from
b488b34
to
f191fbe
Compare
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 97.12% 97.26% +0.13%
==========================================
Files 190 190
Lines 4491 4498 +7
==========================================
+ Hits 4362 4375 +13
+ Misses 129 123 -6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rainerdema
force-pushed
the
nebulab/rainerd/add-message-if-order-is-fully-covered-by-store-credits
branch
from
f191fbe
to
8e5cfaa
Compare
This commit adds a new translation key 'covered_by_store_credit' in en.yml. The new key provides a specific message to inform users when their order is fully covered by store credits, and no additional payment method is required. This change is connected to an update made in Solidus Starter Frontend: solidusio/solidus_starter_frontend#348
This commit adds logic to handle the checkout process for orders that are fully covered by store credits. In the checkout process, we skip the payment selection stage if the order can be entirely covered by store credits. A message is displayed to the user indicating that no additional payment method is required.
rainerdema
force-pushed
the
nebulab/rainerd/add-message-if-order-is-fully-covered-by-store-credits
branch
from
8e5cfaa
to
ecdc45f
Compare
| @@ -3,60 +3,63 @@ | |||
| <legend> | |||
| <%= t('spree.payment_information') %> | |||
| </legend> | |||
| <% if @order.covered_by_store_credit? %> | |||
| <p>Your order is fully covered by store credits, no additional payment method is required.</p> | |||
There was a problem hiding this comment.
as pointed out by @kennyadsl in solidusio/solidus#5208 we can start storing frontend related keys in the starter itself, with time we should end up with a tighter, more coherent list of translations for the core instead of the giant ball of unused ones we currently have.
|
@rainerdema I asked for moving the translation to here, but also wanted to point out that it's great to see this fixed 🙌 |
| @@ -3,60 +3,63 @@ | |||
| <legend> | |||
| <%= t('spree.payment_information') %> | |||
| </legend> | |||
| <% if @order.covered_by_store_credit? %> | |||
| <p>Your order is fully covered by store credits, no additional payment method is required.</p> | |||
There was a problem hiding this comment.
@kennyadsl I think there are ways in which it can be less painful, e.g.:
- move all the deprecated translations in core to a separate locale files (e.g.
solidus/core/config/locales/en.deprecated.yml) - copy the file to the host application as part of the solidus installation/upgrade process
- remove the deprecated file in the next major
kennyadsl
deleted the
nebulab/rainerd/add-message-if-order-is-fully-covered-by-store-credits
branch
Summary
Fixes #345
This PR adds logic to handle the checkout process for orders that are fully covered by store credits.
In the checkout process, we skip the payment selection stage if the order can be entirely covered by store credits.
A message is displayed to the user indicating that no additional payment method is required.
These changes ensure a smoother checkout experience for users who have sufficient store credits to cover their entire order.
solidus_starter_frontend.348.mov
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: