Remove inline context #1916
Remove inline context #1916
Conversation
| @@ -206,7 +206,7 @@ def _validate_request(self, request: KnowledgeManagementCompletionRequest): | |||
| if self.prompt.prefix is None or self.prompt.prefix == '': | |||
| raise LangChainException("The Prompt object provided in the request's objects dictionary is invalid because it is missing a prefix value.", 400) | |||
|
|
|||
| if request.agent.vectorization is not None and not request.agent.inline_context: | |||
| if request.agent.vectorization is not None: | |||
There was a problem hiding this comment.
This change will break things. Most agent definitions have a vectorization object that is not null, but if it can often contain a text_embedding_profile_object_id that is null or ''. This should not result in an error, as these agents legitimately will not need vectorization.
There was a problem hiding this comment.
@kylebunting I'm unclear on what the check should do in combination with the nested checks and exception raises. Could you just make the appropriate corrections?
| @@ -51,7 +51,7 @@ def _get_document_retriever( | |||
| """ | |||
| retriever = None | |||
|
|
|||
| if agent.vectorization is not None and not agent.inline_context: | |||
| if agent.vectorization is not None: | |||
There was a problem hiding this comment.
This shoud also perform a check to verify the text_embedding_profile_object_id is not an empty string, which is the case for many agents.
…ds not null or empty
|
@kylebunting @ciprianjichici I made changes based on the conversation in standup today to make sure the removal of inline context checks did not result in errors where there should not be or null/empty indexing profile object ids. Let me know if there are more changes you think are needed here |
…ies, and having at least one non-empty indexing profile
|
@ciprianjichici This one is lingering. I have tested the Python changes and confirmed they are doing as expected, as well as the dotnet code of course. |
|
@ciprianjichici @codingbandit This one still lingering, do we want to merge this or is it OBE by now due to all the other pipeline changes? |
Remove InlineContext from Agent definitions and orchestration usage
Fixes #{bug number} (in this specific format)
https://dev.azure.com/solliance/FoundationaLLM/_boards/board/t/FoundationaLLM%20Team/Stories/?workitem=19026
https://dev.azure.com/solliance/FoundationaLLM/_boards/board/t/FoundationaLLM%20Team/Stories/?workitem=19223
Details on the issue fix or feature implementation
Removed InlineContext (inline_context in Python and Vue code) from agent definitions
Confirm the following
Note
Instead of adding
X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.