Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource deletions not propagating through service instances #2196

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

joelhulen
Copy link
Contributor

@joelhulen joelhulen commented Feb 13, 2025

Fix resource deletions not propagating through service instances

The issue or feature being addressed

Other instances were not picking up the change when deleting a resource, such as an Agent. For example, the Agent would still appear in the User Portal after deleting it in the Management Portal, or it would reappear in the Management Portal when hitting a different instance of the Management API.

Details on the issue fix or feature implementation

Adds custom equality operators to the ResourceReference class and evaluates in-memory resource references against the list of persisted references, updating the in-memory reference if it is different.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • This PR needs to be cherry-picked into at least one release branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici merged commit cc3456b into main Feb 13, 2025
9 checks passed
@ciprianjichici ciprianjichici deleted the jdh-fix-resource-deletions branch February 13, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants