Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource references for default completion models #2197

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

joelhulen
Copy link
Contributor

@joelhulen joelhulen commented Feb 13, 2025

Fix resource references for default completion models

The issue or feature being addressed

Fixes an issue with duplicate GPT4oCompletionAIModel items returning from the AI Model resource provider.

Details on the issue fix or feature implementation

The DefaultCompletionModel resource reference needs to point to the completion-model.json file instead of the completion-4o-model.json file. Also updated the FoundationaLLM agent template to reference the GPT4oCompletionAIModel resource.

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • This PR needs to be cherry-picked into at least one release branch
  • I have included unit tests for the issue/feature
  • I have included inline docs for my changes, where applicable
  • I have successfully run a local build
  • I have provided the required update scripts, where applicable
  • I have updated relevant docs, where applicable

Note

Instead of adding X's inside the checkboxes you wish to check above, first submit the PR, then check the boxes in the rendered description.

@ciprianjichici ciprianjichici merged commit 6058d04 into main Feb 13, 2025
8 checks passed
@ciprianjichici ciprianjichici deleted the jdh-duplicate-aimodels branch February 13, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants