Added Azure OpenAI Direct E2E Test (Scenario #17) #948
+121
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelhulen
requested changes
May 8, 2024
| @@ -38,19 +37,6 @@ public async Task<AgentBase> CreateAgent(string agentName) | |||
| throw new InvalidOperationException($"The prompt for the agent {agentName} was not found."); | |||
| } | |||
|
|
|||
| // Resolve App Config values for the endpoint configuration as necessary. | |||
There was a problem hiding this comment.
Why did you delete this? This is required to place static values in the orchestration settings of the agents.
There was a problem hiding this comment.
App Config resolution is not needed for AzureOpenAIDirect agents.
There was a problem hiding this comment.
That doesn't matter. It doesn't try to resolve if the value does not start with FoundationaLLM:.
tests/dotnet/Core.Examples/Services/ManagementAPITestManager.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Azure OpenAI Direct E2E Test (Scenario #17)
Details on the issue fix or feature implementation
This PR includes an end-to-end test for the AzureOpenAIDirect orchestrator. It creates a new agent and prompt and requests completion using both endpoints.
Confirm the following