Move CTAPHID commands under a single vendor command #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used one CTAPHID vendor command per application command. This makes it hard to extend the functionality because we have to synchronize the used vendor commands over all applications in the Trussed ecosystem. As an alternative, this patch introduces a new vendor command that acts as a namespace for the admin application. The actual application command is encoded in the first byte of the payload. In the future, we might want to make this configurable so that the runner can decide the namespace used by CTAPHID apps. For compatibility, the CTAPHID vendor commands are still available. This change also allows us to combine the CTAPHID and APDU command handling into a single dispatch function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used one CTAPHID vendor command per application command. This makes it hard to extend the functionality because we have to synchronize the used vendor commands over all applications in the Trussed ecosystem.
As an alternative, this patch introduces a new vendor command that acts as a namespace for the admin application. The actual application command is encoded in the first byte of the payload. In the future, we might want to make this configurable so that the runner can decide the namespace used by CTAPHID apps.
For compatibility, the CTAPHID vendor commands are still available.
This change also allows us to combine the CTAPHID and APDU command handling into a single dispatch function.