Change default comparator to original order

solomonng2001 · Apr 2, 2024 · 2285fc1 · 2285fc1
1 parent f307fbe
commit 2285fc1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/main/java/seedu/address/model/person/PersonComparator.java b/src/main/java/seedu/address/model/person/PersonComparator.java
@@ -1,5 +1,7 @@
 package seedu.address.model.person;
 
+import static seedu.address.model.Model.COMPARATOR_SHOW_ORIGINAL_ORDER;
+
 import java.util.Comparator;
 
 /**
@@ -41,7 +43,7 @@ public static Comparator<Person> getComparator(SortCriteria sortCriteria, SortOr
             comparator = Comparator.comparing(Person::getSchedule);
             break;
         default:
-            return Comparator.comparing(Person::getName);
+            return COMPARATOR_SHOW_ORIGINAL_ORDER;
         }
         if (sortOrder == SortOrder.DESC) {
             return comparator.reversed();

diff --git a/src/test/java/seedu/address/model/person/PersonComparatorTest.java b/src/test/java/seedu/address/model/person/PersonComparatorTest.java
@@ -95,10 +95,10 @@ public void getComparator() {
         // sort by invalid or default criteria
         Comparator<Person> invalidAscComparator = PersonComparator.getComparator(SortCriteria.INVALID, SortOrder.ASC);
         // ascending
-        assertTrue(invalidAscComparator.compare(alice, bob) < 0);
+        assertTrue(invalidAscComparator.compare(alice, bob) == 0);
         assertEquals(0, invalidAscComparator.compare(alice, aliceCopy));
         // descending
-        assertTrue(invalidAscComparator.compare(alice, bob) < 0);
+        assertTrue(invalidAscComparator.compare(alice, bob) == 0);
         assertEquals(0, invalidAscComparator.compare(alice, aliceCopy));
     }
 }