Skip to content

Conversation

rofl0r
Copy link
Collaborator

@rofl0r rofl0r commented Oct 7, 2021

according to what was recently discussed in #musl.

according to what was recently discussed in `#musl`.
Copy link
Collaborator

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this suggestion... A script that like is prone to invoking whatever is in the interpreter field... I think recommending that the script contain /lib/ld-musl... --list for your arch is more correct.

@rofl0r
Copy link
Collaborator Author

rofl0r commented Oct 9, 2021

A script that like is prone to invoking whatever is in the interpreter field...

Jun 04 04:24:45 <dalias> [02:21:41] a proper ldd should get the PT_INTERP from the binary then execute it with --list

rofl0r and others added 2 commits October 9, 2021 22:49
Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
@ericonr
Copy link
Collaborator

ericonr commented Oct 10, 2021

Yes, i disagree with dalias's suggestion. It only matters for a multilib/multiarch system, and even then, I'd rather be told that a given binary is not what I expected. It opens up too much for little gain.

@ericonr
Copy link
Collaborator

ericonr commented Oct 10, 2021

Also I think squashing the commits would be nice.

@rofl0r
Copy link
Collaborator Author

rofl0r commented Oct 10, 2021

Also I think squashing the commits would be nice.

certainly. i was just about to hit the "squash and merge" button, but to my surprise it isn't enabled for this repo. do you have admin rights to change that ?

@ericonr
Copy link
Collaborator

ericonr commented Oct 10, 2021

<dalias> it's literally just exec /lib/ld-musl-x86_64.so.1 --list "$@"
<dalias> the gratuitously complicted one is trying to support multiple archs from one script
<dalias> rather than just hardcoding the right pathname

@ericonr
Copy link
Collaborator

ericonr commented Oct 10, 2021

I don't think I have the privileges, no. Squashing locally with git leads to a cleaner commit message too...

@ericonr
Copy link
Collaborator

ericonr commented Oct 10, 2021

And rebase makes for a more linear git history, which is all this really needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants