Skip to content

chore: add environment variable for API key request #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
somramnani merged 1 commit into from
Nov 23, 2024
Merged

chore: add environment variable for API key request #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/routes/superHeroAPI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const router = express.Router();
router.get("/:data", async (req, res) => {
await axios({
method: "get",
url: `https://superheroapi.com/api/88fa1b97046d4d9666b719510bbb8257/search/${req.params.data}`,
url: `https://superheroapi.com/api/${process.env.SUPERHERO_API_KEY}/search/${req.params.data}`,
})
.then(function (response) {
return res.send(response.data);
Expand Down
4 changes: 2 additions & 2 deletions coverage/clover.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<coverage generated="1732347860732" clover="3.2.0">
<project timestamp="1732347860732" name="All files">
<coverage generated="1732348606980" clover="3.2.0">
<project timestamp="1732348606980" name="All files">
<metrics statements="29" coveredstatements="26" conditionals="4" coveredconditionals="3" methods="6" coveredmethods="4" elements="39" coveredelements="33" complexity="0" loc="29" ncloc="29" packages="2" files="3" classes="3"/>
<package name="api">
<metrics statements="17" coveredstatements="15" conditionals="4" coveredconditionals="3" methods="2" coveredmethods="1"/>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/api/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ <h1><a href="../index.html">All files</a> api</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/api/index.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ <h1><a href="../index.html">All files</a> / <a href="index.html">api</a> index.j
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/api/routes/hello.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">api/routes</
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/api/routes/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ <h1><a href="../../index.html">All files</a> api/routes</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
4 changes: 2 additions & 2 deletions coverage/lcov-report/api/routes/superHeroAPI.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">api/routes</
router.get("/:data", async (req, res) =&gt; {
await axios({
method: "get",
url: `https://superheroapi.com/api/88fa1b97046d4d9666b719510bbb8257/search/${req.params.data}`,
url: `https://superheroapi.com/api/${process.env.SUPERHERO_API_KEY}/search/${req.params.data}`,
})
.then(function (response) {
return res.send(response.data);
Expand All @@ -124,7 +124,7 @@ <h1><a href="../../index.html">All files</a> / <a href="index.html">api/routes</
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="../../prettify.js"></script>
<script>
Expand Down
2 changes: 1 addition & 1 deletion coverage/lcov-report/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ <h1>All files</h1>
<div class='footer quiet pad2 space-top1 center small'>
Code coverage generated by
<a href="https://istanbul.js.org/" target="_blank" rel="noopener noreferrer">istanbul</a>
at 2024-11-23T07:44:20.728Z
at 2024-11-23T07:56:46.974Z
</div>
<script src="prettify.js"></script>
<script>
Expand Down