Skip to content

Update Sonar token reference in build workflow #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damesx04 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Sonar token reference in build workflow #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: SonarQube Scan
uses: SonarSource/sonarqube-scan-action@v4
env:
SONAR_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }} # Put the name of your token here
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secret name is being changed from SONARCLOUD_TOKEN to SONAR_TOKEN, but the configuration in sonar-project.properties indicates this is a SonarCloud setup (contains sonar.organization which is SonarCloud-specific). While the sonarqube-scan-action accepts SONAR_TOKEN as the environment variable name for both SonarQube and SonarCloud, the original name SONARCLOUD_TOKEN was more descriptive for this SonarCloud setup.

Consider:

  1. If this is intentional to standardize on SONAR_TOKEN, ensure the GitHub secret is renamed from SONARCLOUD_TOKEN to SONAR_TOKEN in the repository settings, or
  2. Keep using SONARCLOUD_TOKEN for clarity since this is a SonarCloud setup, not a self-hosted SonarQube instance.
Suggested change
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} # Put the name of your token here
SONARCLOUD_TOKEN: ${{ secrets.SONARCLOUD_TOKEN }} # Put the name of your SonarCloud token here

Copilot uses AI. Check for mistakes.
with:
args: >
--define sonar.cfamily.compile-commands="${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json"
Expand Down