Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Fix broken setOption & add unit test #13

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/cjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -1272,10 +1272,10 @@ Constraint = function (value, options) {
this._options[arg0] = arg1;
to_invalidate = indexOf(invalidation_arguments, arg0) >= 0;
} else {
var keys = keys(arg0);
var arg0_keys = keys(arg0);
extend(this._options, arg0);
to_invalidate = any(invalidation_arguments, function(ia) {
return keys.indexOf(ia) >= 0;
return arg0_keys.indexOf(ia) >= 0;
});
}

Expand Down
2 changes: 1 addition & 1 deletion build/cjs.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/cjs.min.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions src/core.js
Original file line number Diff line number Diff line change
Expand Up @@ -627,10 +627,10 @@ Constraint = function (value, options) {
this._options[arg0] = arg1;
to_invalidate = indexOf(invalidation_arguments, arg0) >= 0;
} else {
var keys = keys(arg0);
var arg0_keys = keys(arg0);
extend(this._options, arg0);
to_invalidate = any(invalidation_arguments, function(ia) {
return keys.indexOf(ia) >= 0;
return arg0_keys.indexOf(ia) >= 0;
});
}

Expand Down
18 changes: 18 additions & 0 deletions test/unit_tests/constraint_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,21 @@ dt("Nullify check infinite loop", 4, function() {
y.set(function(){return z.get()+1});
equal(z.get(), 1);
});

dt("Set Option", 3, function() {
var f = function(){
return 1;
}
var x = cjs(f);

equal(x.get(), 1);

x.setOption({ literal: true });
equal(x.get(), f);

x.setOption({ literal: false });
equal(x.get(), 1);

x.destroy();
x = null;
});