Enhacements for Overlay-Ecmp #1771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
Signed-off-by: siqbal1986 <shahzad.iqbal@microsoft.com>
siqbal1986
commented
Sep 10, 2024
|
|
||
|
|
||
| ## 3.2 Custom monitoring for VTEP liveness detection. | ||
| In the orignal design of Overlay-ECMP, BFD was used for livness detection fo VTEP. But BFD may not be supported by all types of VTEPs. In some cases a user may want to use their own custom protocol for livness detection. This enhacement allows for such a mechanism. The Orchagent creates an entry in the VNET_MONITOR_TABLE in APP DB if it recieves the "monitoring" = "custom" attribute in the VNET_ROUTE_TUNNEL_TABLE entry. The orchaagent then listens on VNET_MONITOR_TABLE in the STATE DB to monitor the livness of the VTEP. |
There was a problem hiding this comment.
add a diagram to futher explain this . how the custom monitoring is chosen and that we cannot have both custom and BFD monitoring in the same tunnel route endpoints.
| | Multiple primary backups. Multiple primary recovery. Endpoint list = [A, B, C, A’, A’, B’, C’] Primary = [A, B, C] | NH = [A] | A is Up. B, C also come up | NH=[A, B, C] | Primary endpoints take precedence and are added to the NH. | | ||
|
|
||
|
|
||
| ## 3.2 Custom monitoring for VTEP liveness detection. |
There was a problem hiding this comment.
Can we capture the module interaction as well for custom monitoring by enhancing the diagram ?
| A new table in state DB is being added to recieve the response form the custom monitoring module to indicate endpoint liveness. | ||
|
|
||
| ``` | ||
| VNET_MONITOR_TABLE|{{endpoint}}|{{ip_addr}} |
There was a problem hiding this comment.
Dont we need vnet_name also as a key?
| A new table **VNET_MONITOR_TABLE** has been added to send the endpoint information to the custom monitoring module. | ||
|
|
||
| ``` | ||
| VNET_MONITOR_TABLE:{{endpoint}}:{{ip_prefix}} |
There was a problem hiding this comment.
Dont we need vnet_name also as a key?
| @@ -0,0 +1,227 @@ | |||
| # Overlay ECMP Enhancements | |||
|
|
|||
There was a problem hiding this comment.
Fix the typo. in the title of this HLD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document describes various enhancements for Overlay-Ecmp feature.