Add YANG models for configurable drop monitor feature#22589
Merged
yxieca merged 2 commits intosonic-net:masterfrom Jun 16, 2025
Merged
Add YANG models for configurable drop monitor feature#22589yxieca merged 2 commits intosonic-net:masterfrom
yxieca merged 2 commits intosonic-net:masterfrom
Conversation
Added the following tables: - DEBUG_DROP_MONITOR - DEBUG_DROP_MONITOR_STATS - PERSISTENT_DROP_ALERTS Modified the following tables: - DEBUG_COUNTER
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… yang-models These tables belongs to counters DB and hence should not need a yang model
arista-hpandya
force-pushed
the
drop-counter-yang
branch
from
5029204 to
59e8199
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
requested changes
May 20, 2025
Contributor
vmittal-msft
left a comment
vmittal-msft
left a comment
There was a problem hiding this comment.
@arista-hpandya i left some comments in HLD PR. please share your thoughts on those. Else these changes are mostly in-line with HLD
Contributor
|
@qiluo-msft : can you also review this ? |
vmittal-msft
approved these changes
Jun 14, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the YANG model definition for the
DEBUG_DROP_MONITORtables to the SONiC yang models repository. The new YANG model defines the schema for configuring and monitoring persistent drop counters in SONiC.Changes:
Why I did it
To provide a standardized and programmatic way to configure and monitor persistent drop counters in SONiC. This enhances the manageability and observability of network traffic.
Work item tracking
Fixes #21675
HLD: sonic-net/SONiC#1912
How I did it
Created a new YANG model file, implemented test cases for validation, and updated the relevant documentation.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)