Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add one_dut fixture to only use one dut #16197

Merged

Conversation

auspham
Copy link
Contributor

@auspham auspham commented Dec 23, 2024

Description of PR

Summary:

Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time

Fixes # (issue) 30562817

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Reducing the number of DUT but still give enough priorities for coverage

How did you do it?

Modify the current fixture to add an option to pick 1 DUT for testing only

How did you verify/test it?

physical testbed

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham
Copy link
Contributor Author

auspham commented Dec 23, 2024

@sdszhang for viz

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yejianquan yejianquan merged commit 78787cc into sonic-net:master Dec 24, 2024
19 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Dec 24, 2024
Description of PR
Summary:

Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time

Fixes # (issue) 30562817

Approach
What is the motivation for this PR?
Reducing the number of DUT but still give enough priorities for coverage

How did you do it?
Modify the current fixture to add an option to pick 1 DUT for testing only

How did you verify/test it?
physical testbed

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #16211

mssonicbld pushed a commit that referenced this pull request Jan 2, 2025
Description of PR
Summary:

Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time

Fixes # (issue) 30562817

Approach
What is the motivation for this PR?
Reducing the number of DUT but still give enough priorities for coverage

How did you do it?
Modify the current fixture to add an option to pick 1 DUT for testing only

How did you verify/test it?
physical testbed

Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 3, 2025
Description of PR
Summary:

Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time

Fixes # (issue) 30562817

Approach
What is the motivation for this PR?
Reducing the number of DUT but still give enough priorities for coverage

How did you do it?
Modify the current fixture to add an option to pick 1 DUT for testing only

How did you verify/test it?
physical testbed

Signed-off-by: Austin Pham <austinpham@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16326

mssonicbld pushed a commit that referenced this pull request Jan 3, 2025
Description of PR
Summary:

Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time

Fixes # (issue) 30562817

Approach
What is the motivation for this PR?
Reducing the number of DUT but still give enough priorities for coverage

How did you do it?
Modify the current fixture to add an option to pick 1 DUT for testing only

How did you verify/test it?
physical testbed

Signed-off-by: Austin Pham <austinpham@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants