-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add one_dut fixture to only use one dut #16197
Merged
yejianquan
merged 1 commit into
sonic-net:master
from
auspham:austinpham/30562817-params-reduction-ixia
Dec 24, 2024
Merged
feat: add one_dut fixture to only use one dut #16197
yejianquan
merged 1 commit into
sonic-net:master
from
auspham:austinpham/30562817-params-reduction-ixia
Dec 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Austin Pham <austinpham@microsoft.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@sdszhang for viz |
sdszhang
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cyw233
approved these changes
Dec 24, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 24, 2024
Description of PR Summary: Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time Fixes # (issue) 30562817 Approach What is the motivation for this PR? Reducing the number of DUT but still give enough priorities for coverage How did you do it? Modify the current fixture to add an option to pick 1 DUT for testing only How did you verify/test it? physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
Cherry-pick PR to 202405: #16211 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 2, 2025
Description of PR Summary: Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time Fixes # (issue) 30562817 Approach What is the motivation for this PR? Reducing the number of DUT but still give enough priorities for coverage How did you do it? Modify the current fixture to add an option to pick 1 DUT for testing only How did you verify/test it? physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Jan 2, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jan 3, 2025
Description of PR Summary: Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time Fixes # (issue) 30562817 Approach What is the motivation for this PR? Reducing the number of DUT but still give enough priorities for coverage How did you do it? Modify the current fixture to add an option to pick 1 DUT for testing only How did you verify/test it? physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
Cherry-pick PR to 202411: #16326 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jan 3, 2025
Description of PR Summary: Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time Fixes # (issue) 30562817 Approach What is the motivation for this PR? Reducing the number of DUT but still give enough priorities for coverage How did you do it? Modify the current fixture to add an option to pick 1 DUT for testing only How did you verify/test it? physical testbed Signed-off-by: Austin Pham <austinpham@microsoft.com>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Currently, test_pfc_pause_single_lossy_prio and test_pfc_pause_single_lossy_prio_reboot are using more parameters than its needed, resulting in a longer execution time
Fixes # (issue) 30562817
Type of change
Back port request
Approach
What is the motivation for this PR?
Reducing the number of DUT but still give enough priorities for coverage
How did you do it?
Modify the current fixture to add an option to pick 1 DUT for testing only
How did you verify/test it?
physical testbed
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation