-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce 2 test for System Health: System health fan direction and system health led #16223
base: master
Are you sure you want to change the base?
Introduce 2 test for System Health: System health fan direction and system health led #16223
Conversation
… led * test_fan_direction_alarm Add test case to test the abiliby for system-health's detection fan direction * test_system_health_led Add test case to test the led color is as expected as defined in system_health configuration file.
…system_health_led
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@prgeor , all the check are passed. Please review and merge this PR, thanks. |
Can you verfiy that if these two added scripts can run on kvm testbed? |
Hi, @yutongzhang-microsoft , I am sorry that I have no such environment for verification. |
As the topology mark is |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @yutongzhang-microsoft , the 2 test cases are skipped on the KVM platform. |
…t the pipeline to check.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
the 2 test cases are add into onboarding-t0 and onboarding-t1 PR checker list. |
Great! Thanks! |
|
||
system_health/test_system_health_led.py: | ||
skip: | ||
reason: "There is no table SYSTEM_HEALTH_INFO in STATE_DB on kvm testbed, skip in PR testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of PR
Summary:
Introduce 2 test for System Health: System health fan direction and system health led
test_system_health_fan_direction.py::
test_system_health_led.py::
Type of change
Back port request
Approach
What is the motivation for this PR?
Introduce 2 new test cases for system-health feature.
How did you do it?
Implement the 2 test cases.
test_system_health_fan_direction::
test_system_health_led::
How did you verify/test it?
Run the 2 test cases.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation