Skip to content

Comments

Align the deploy script for smartswitch dark mode#20415

Merged
prabhataravind merged 2 commits intosonic-net:masterfrom
JibinBao:updte_gen_config_dark_mode
Oct 18, 2025
Merged

Align the deploy script for smartswitch dark mode#20415
prabhataravind merged 2 commits intosonic-net:masterfrom
JibinBao:updte_gen_config_dark_mode

Conversation

@JibinBao
Copy link
Contributor

@JibinBao JibinBao commented Aug 27, 2025 •
edited
Loading

Description of PR

Align the deploy script for smartswitch dark mode. Because when smartswitch is dark mode, the dpus are shutdown, so we need to skip the config related to the dpus.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Align the deploy script with community for smartswitch dark mode

How did you do it?

When smartswitch is dark mode, skip the config related to dpu.

How did you verify/test it?

deploy smartswitch with dark mode

Any platform specific information?

Smartswitch

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 27, 2025

/azp run

@JibinBao JibinBao changed the title Align the deploy script with community for smartswitch dark mode Align the deploy script for smartswitch dark mode Aug 27, 2025
@azure-pipelines
Copy link

azure-pipelines bot commented Aug 27, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao JibinBao force-pushed the updte_gen_config_dark_mode branch from 9404fee to f45bf73 Compare August 27, 2025 03:21
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 27, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 27, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 1, 2025

Hi @wangxin @yxieca ,
Could you please check why my PRs all failed on the step of Prepare Testebed? I have re-run it many times, but it didn't work.
image

@JibinBao JibinBao force-pushed the updte_gen_config_dark_mode branch from f45bf73 to eb30591 Compare September 17, 2025 02:22
@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 17, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 17, 2025

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 17, 2025

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 18, 2025

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 18, 2025

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 18, 2025

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 18, 2025

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 18, 2025

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 18, 2025

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 18, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao JibinBao force-pushed the updte_gen_config_dark_mode branch from eb30591 to 6e02347 Compare September 19, 2025 02:09
@mssonicbld
Copy link
Collaborator

mssonicbld commented Sep 19, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Contributor Author

JibinBao commented Sep 19, 2025 •
edited
Loading

hi @wangxin @yxieca ,
Could you please check the failures which looks like not related to my change? I have re-run it many times, it always failed du to the following error.

  • docker exec -w /var/src/sonic-mgmt/ansible sonic-mgmt bash -c ./testbed-cli.sh -m veos_vtb -t vtestbed.yaml deploy-mg vms-kvm-t0 veos_vtb password.txt -e vlan_config=two_vlan_a
    Deploying minigraph to testbed 'vms-kvm-t0'
    reading
    found testbed vms-kvm-t0
    /usr/local/lib/python3.8/dist-packages/paramiko/transport.py:236: CryptographyDeprecationWarning: Blowfish has been deprecated
    "class": algorithms.Blowfish,
    usage: ansible-playbook [-h] [--version] [-v] [--private-key PRIVATE_KEY_FILE]
    [-u REMOTE_USER] [-c CONNECTION] [-T TIMEOUT]
    [--ssh-common-args SSH_COMMON_ARGS]
    [--sftp-extra-args SFTP_EXTRA_ARGS]
    [--scp-extra-args SCP_EXTRA_ARGS]
    [--ssh-extra-args SSH_EXTRA_ARGS]
    [-k | --connection-password-file CONNECTION_PASSWORD_FILE]
    [--force-handlers] [--flush-cache] [-b]
    [--become-method BECOME_METHOD]
    [--become-user BECOME_USER]
    [-K | --become-password-file BECOME_PASSWORD_FILE]
    [-t TAGS] [--skip-tags SKIP_TAGS] [-C]
    [--syntax-check] [-D] [-i INVENTORY] [--list-hosts]
    [-l SUBSET] [-e EXTRA_VARS] [--vault-id VAULT_IDS]
    [--ask-vault-password | --vault-password-file VAULT_PASSWORD_FILES]
    [-f FORKS] [-M MODULE_PATH] [--list-tasks]
    [--list-tags] [--step] [--start-at-task START_AT_TASK]
    playbook [playbook ...]
    ansible-playbook: error: unrecognized arguments: vlan_config=two_vlan_a

@prabhataravind
Copy link
Contributor

prabhataravind commented Oct 18, 2025

@JibinBao please also raise a separate PR for 202506 branch. There is a conflict.

JibinBao added a commit to JibinBao/sonic-mgmt that referenced this pull request Oct 20, 2025
@JibinBao
Align the deploy script for smartswitch dark mode (sonic-net#20415)
711e283 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
JibinBao added a commit to JibinBao/sonic-mgmt that referenced this pull request Oct 20, 2025
@JibinBao
Align the deploy script for smartswitch dark mode (sonic-net#20415)
e3b3757 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
JibinBao added a commit to JibinBao/sonic-mgmt that referenced this pull request Oct 20, 2025
@JibinBao
Align the deploy script for smartswitch dark mode (sonic-net#20415)
75839c4 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
@JibinBao JibinBao mentioned this pull request Oct 20, 2025
Merged
11 tasks
@JibinBao
Copy link
Contributor Author

JibinBao commented Oct 20, 2025

@JibinBao please also raise a separate PR for 202506 branch. There is a conflict.

Done: Azure/sonic-mgmt.msft#770, please review it.

@JibinBao JibinBao mentioned this pull request Oct 20, 2025
Open
11 tasks
vidyac86 pushed a commit to vidyac86/sonic-mgmt that referenced this pull request Oct 23, 2025
@JibinBao @vidyac86
Align the deploy script for smartswitch dark mode (sonic-net#20415)
d7e7a76 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
roy-sror pushed a commit that referenced this pull request Oct 27, 2025
@JibinBao
Align the deploy script for smartswitch dark mode (#20415) (#21029)
f7b9950 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
@JibinBao @dcaugher
Align the deploy script for smartswitch dark mode (sonic-net#20415)
c8f3126 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
@JibinBao @dcaugher
Align the deploy script for smartswitch dark mode (sonic-net#20415)
e116987 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Nov 18, 2025
@JibinBao @saravanan-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
dfd28e1 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
vikumarks pushed a commit to vikumarks/sonic-mgmt that referenced this pull request Dec 1, 2025
@JibinBao @vikumarks
Align the deploy script for smartswitch dark mode (sonic-net#20415)
59d7164 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: vikumarks <vikumar7ks@gmail.com>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@JibinBao
Align the deploy script for smartswitch dark mode (sonic-net#20415)
2aa4406 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
@JibinBao @selldinesh
Align the deploy script for smartswitch dark mode (sonic-net#20415)
4590686 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
@JibinBao @echuawu
Align the deploy script for smartswitch dark mode (sonic-net#20415)
b557348 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
@JibinBao @saravanan-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
e1de03b 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@JibinBao @gshemesh2
Align the deploy script for smartswitch dark mode (sonic-net#20415)
c67f0f2 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@JibinBao @AharonMalkin
Align the deploy script for smartswitch dark mode (sonic-net#20415)
3473e6e 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@JibinBao @gshemesh2
Align the deploy script for smartswitch dark mode (sonic-net#20415)
f3af679 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@JibinBao @venu-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
f1119f2 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
@JibinBao @yifan-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
c505a81 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: YiFan Wang <yifan@nexthop.ai>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@JibinBao @gshemesh2
Align the deploy script for smartswitch dark mode (sonic-net#20415)
25b668b 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
@JibinBao @lakshmi-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
6755957 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Lakshmi Yarramaneni <lakshmi@nexthop.ai>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
@JibinBao @ytzur1
Align the deploy script for smartswitch dark mode (sonic-net#20415)
df00311 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@JibinBao @ytzur1
Align the deploy script for smartswitch dark mode (sonic-net#20415)
f15aa56 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
@JibinBao @abhishek-nexthop
Align the deploy script for smartswitch dark mode (sonic-net#20415)
97e4bb2 
* Align the deploy script with community for smartswitch dark mode

* fix issue deploy_mg issue

We don't need to handle the parameters for the Ansible playbook individually; they can be passed to Ansible as a whole using $@.
@prabhataravind prabhataravind mentioned this pull request Feb 19, 2026
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prabhataravind prabhataravind prabhataravind approved these changes

@wangxin wangxin Awaiting requested review from wangxin

@yxieca yxieca Awaiting requested review from yxieca

@wen587 wen587 Awaiting requested review from wen587

+1 more reviewer

@nhe-NV nhe-NV nhe-NV approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved for msft-202506 Branch Cherry Pick Conflict_msft-202506 Request for msft-202506 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JibinBao @mssonicbld @prabhataravind @nhe-NV