Fix telemetry/test_events.py for v6 topos#21649
Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom Jan 30, 2026
Merged
Fix telemetry/test_events.py for v6 topos#21649StormLiangMS merged 3 commits intosonic-net:masterfrom
StormLiangMS merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: markxiao <markxiao@arista.com>
Collaborator
|
/azp run |
github-actions
bot
requested review from
guangyao6,
lizhijianrd,
wangxin,
wsycqyz,
xwjiang-ms,
yejianquan and
zbud-msft
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidm-arista
added
Request for msft-202412 Branch
Request for 202511 branch
12 tasks
| is_v6_topo = is_ipv6_only_topology(tbinfo) | ||
|
|
||
| # Get all BGP neighbors and filter by IP version based on management interface | ||
| # Get all BGP neighbors and filter by IP version based on v6/non-v6 topo |
Collaborator
There was a problem hiding this comment.
what's the difference between ipv6 mgmt and v6 only topo? @markx-arista
Contributor
Author
There was a problem hiding this comment.
IPv6 mgmt only setup: management interface on the DUT only has IPv6 address configured
IPv6 only topo: only contains IPv6 neighbors in the topo
This test checks for neighbors, so we definitely should check for IPv6 neighbors on v6 topo. On IPv6 mgmt only setup, both v4 and v6 neighbors still exist, so I don't know why the original code made this change.
Collaborator
|
hi @markx-arista could you check the cherrypick conflict? |
7 tasks
Contributor
Author
|
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com>
Anirudh-nokia
pushed a commit
to Anirudh-nokia/sonic-mgmt-fork
that referenced
this pull request
Feb 6, 2026
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: ayya <anirudh.ayya@nokia.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Summary: Fix the following telemetry events for v6 topos: sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup. sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle() dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future Fixes sonic-net#21648 Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fix the following telemetry events for v6 topos:
sonic-events-bgp:notification: Utilize the fix for mgmt ipv6 only setup that uses ip6tables on v6 neighbors for v6 topos. Delete the condition for mgmt ipv6 only setup because v4 neighbors still exist in that setup.
sonic-events-bgp:bgp-state: Consider v6 neighbors in is_bgp_state_idle()
dhcp-relay events: dhcpmon doesn't support v6 topo because it requires ipv4 addr configured on VLAN interface, skip the test for v6 topo
Pass tbinfo to trigger functions, currently only drop_tcp_packets uses it, but more functions (e.g., dhcp-relay if dhcpmon is fixed) will need it in the future
Fixes #21648
Type of change
Back port request
Approach
What is the motivation for this PR?
telemetry/test_events.py failed on v6 topos in the following cases:
bgp_events.py
dhcp-relay_events.py
How did you do it?
Add proper v6 fix and skip.
How did you verify/test it?
The test passed on v6 topos.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation