skip allow_list for isolated topo.#21698
Merged
StormLiangMS merged 2 commits intosonic-net:masterfrom Dec 24, 2025
Merged
Conversation
Collaborator
|
/azp run |
github-actions
bot
requested review from
BYGX-wcr,
xwjiang-ms and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
force-pushed
the
skip_allow_list
branch
from
71d980d to
6b084fd
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
added
Request for 202505 branch
Request for 202511 branch
r12f
approved these changes
Dec 17, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
# Conflicts: # tests/common/plugins/conditional_mark/tests_mark_conditions.yaml Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
sdszhang
force-pushed
the
skip_allow_list
branch
from
7387f49 to
f99161b
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 24, 2025
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Collaborator
|
Cherry-pick PR to 202505: #21778 |
12 tasks
vrajeshe
pushed a commit
to Akshath-17/sonic-mgmt
that referenced
this pull request
Jan 4, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
mssonicbld
pushed a commit
that referenced
this pull request
Jan 9, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: YiFan Wang <yifan@nexthop.ai>
vmittal-msft
added
Approved for 202511 branch
and removed
Approved for 202511 branch
labels
Collaborator
|
@sdszhang PR conflicts with 202511 branch |
PriyanshTratiya
pushed a commit
to PriyanshTratiya/sonic-mgmt
that referenced
this pull request
Jan 21, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
12 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#1026 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Description of PR Summary: test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image. https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24 as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
test_bgp_allow_list.py relies on the ALLOW_LIST route-map which comes from image.
https://github.com/sonic-net/sonic-buildimage/blob/371543340a65eb26f17ad98d394295158de3d9e9/dockers/docker-fpm-frr/frr/bgpd/templates/general/policies.conf.j2#L24
as allow_list is not needed in t1-isolated topo, which will cover both 400g.t1 and 100g.t1 hwsku.
Type of change
Back port request
Approach
What is the motivation for this PR?
fix test_bgp_allow_list failure in isolated topo.
How did you do it?
skipped in mark condition.
How did you verify/test it?
local testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation