Skip to content

Comments

Fix test_configurable_drop_counters.py for v6 topos#21763

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
markx-arista:master-fix-test-configurable-drop-counters-for-v6-topo
Feb 17, 2026
Merged

Fix test_configurable_drop_counters.py for v6 topos#21763
StormLiangMS merged 1 commit intosonic-net:masterfrom
markx-arista:master-fix-test-configurable-drop-counters-for-v6-topo

Conversation

@markx-arista
Copy link
Contributor

Description of PR

Summary:
Fix test_neighbor_link_down for v6 topo and remove xfail
Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons for IPv6 packets
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202412
  • 202505

Approach

What is the motivation for this PR?

test_configurable_drop_counters.py failed on v6 topos

How did you do it?

Fix test cases for V6 topos, and skip test_dip_link_local/test_sip_link_local for V6 topo with Broadcom Asics

How did you verify/test it?

test_neighbor_link_down passed on V6 topos and test_dip_link_local/test_sip_link_local are skipped on V6 topos with Broadcom Asics

Any platform specific information?

Broadcom Asics don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop reasons for IPv6 packets

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista markx-arista force-pushed the master-fix-test-configurable-drop-counters-for-v6-topo branch from 4bdd715 to 574e76d Compare December 19, 2025 20:30
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista markx-arista force-pushed the master-fix-test-configurable-drop-counters-for-v6-topo branch from 574e76d to 00bb50e Compare December 19, 2025 20:34
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markx-arista markx-arista force-pushed the master-fix-test-configurable-drop-counters-for-v6-topo branch from 00bb50e to ceea77a Compare December 23, 2025 04:32
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Fix test_neighbor_link_down for v6 topo
Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for
Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop
reasons for IPv6 packets

Signed-off-by: markxiao <markxiao@arista.com>
@markx-arista markx-arista force-pushed the master-fix-test-configurable-drop-counters-for-v6-topo branch from ceea77a to 200b4ef Compare December 23, 2025 04:35
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yanmo96 yanmo96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markx-arista
Copy link
Contributor Author

Cherry-pick to 202412: Azure/sonic-mgmt.msft#1019

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit fb5a98b into sonic-net:master Feb 17, 2026
24 checks passed
@r12f
Copy link
Contributor

r12f commented Feb 19, 2026

Picking to 202412: Azure/sonic-mgmt.msft#1019

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 19, 2026
Fix test_neighbor_link_down for v6 topo
Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for
Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop
reasons for IPv6 packets

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #22476

@markx-arista
Copy link
Contributor Author

@r12f
I just made an additional change to this:
#22482
test_sip_link_local/test_dip_link_local should be skipped for everyone on v6 topo, instead of Broadcom ASIC only. Could you take a look?

anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
Fix test_neighbor_link_down for v6 topo
Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for
Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop
reasons for IPv6 packets

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
mssonicbld pushed a commit that referenced this pull request Feb 20, 2026
Fix test_neighbor_link_down for v6 topo
Fix test_dip_link_local and test_sip_link_local for v6 topo, but skip them for
Broadcom Asics because they don't support DIP_LINK_LOCAL/SIP_LINK_LOCAL drop
reasons for IPv6 packets

Signed-off-by: markxiao <markxiao@arista.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants