Skip to content

Comments

[action] [PR:20932] Adjusting test_stress_arp is it can handle cases of ipv6-only topologies .#22112

Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld:cherry/202511/20932
Open

[action] [PR:20932] Adjusting test_stress_arp is it can handle cases of ipv6-only topologies .#22112
mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld:cherry/202511/20932

Conversation

@mssonicbld
Copy link
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Adjusting test_stress_arp is it can handle cases of ipv6-only topologies .

How did you do it?

In IPv6-only topologies, use 'ip -6 neigh flush all' insted of 'ip -stats neigh flush all' to make it more focus on IPv6 only, and reduce the chance of unsuccessful execution of a command.

Add skip for test_ipv4_arp in case of ipv6 only topology.

How did you verify/test it?

Ran it on Nvidia platforms in IPv6 and IPv4 topologies.

Any platform specific information?

No

Supported testbed topology if it's a new test case?

IPv6 and IPv4 topologies.

Documentation

…ies . (sonic-net#20932)

In IPv6-only topologies, use 'ip -6 neigh flush all' insted of 'ip -stats neigh flush all' to make it more focus on IPv6 only, and reduce the chance of unsuccessful execution of a command.

Add skip for test_ipv4_arp in case of ipv6 only topology.
@mssonicbld
Copy link
Collaborator Author

/azp run

@mssonicbld
Copy link
Collaborator Author

Original PR: #20932

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radha-danda
Copy link

/azpw run Azure.sonic-mgmt

1 similar comment
@radha-danda
Copy link

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator Author

/AzurePipelines run Azure.sonic-mgmt

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radha-danda
Copy link

@gshemesh2, Please check pre-commit checks are failing as part of the PR

Pre-commit check failure logs:
while constructing a mapping
 in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 9, column 1
found duplicate key "arp/test_stress_arp.py::test_ipv4_arp" with value "{}" (original value: "{}")
 in "tests/common/plugins/conditional_mark/tests_mark_conditions.yaml", line 181, column 1

@vmittal-msft, FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants