You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
HA setup fixtures are empty: setup_dash_ha_from_json and activate_dash_ha_from_json in tests/ha/conftest.py are fixtures but just 'pass'. test_ha_steady_state_pl depends on them, so HA setup/activation never happens.
Teardown uses dpuhost out of scope: in common_setup_teardown, dpuhost is defined inside the for-loop. After yield, config_reload(dpuhost, ...) may reference only the last dpuhost or be undefined if skip_config returned early. Consider iterating all dpuhosts in teardown or moving dpuhost into outer scope.
HA setup fixtures are empty: setup_dash_ha_from_json and activate_dash_ha_from_json in tests/ha/conftest.py are fixtures but just 'pass'. test_ha_steady_state_pl depends on them, so HA setup/activation never happens.
Teardown uses dpuhost out of scope: in common_setup_teardown, dpuhost is defined inside the for-loop. After yield, config_reload(dpuhost, ...) may reference only the last dpuhost or be undefined if skip_config returned early. Consider iterating all dpuhosts in teardown or moving dpuhost into outer scope.
Sure, issue 1 is well understood. After the PR that implements those 2 functions gets merged this PR will get updated.
I took care of issue 2 in my latest commit.
Azure Pipelines successfully started running 1 pipeline(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
HA test code with PL config and traffic
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add HA test with PL traffic
How did you do it?
Added tests
How did you verify/test it?
Run it on HA topology
Any platform specific information?
HA topology for MTFuji
Supported testbed topology if it's a new test case?
HA topology
Documentation