Change dummy ip for fill packets to eliminate false positives#22259
Merged
yxieca merged 1 commit intosonic-net:masterfrom Feb 10, 2026
Merged
Change dummy ip for fill packets to eliminate false positives#22259yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
Signed-off-by: Ryan Garofano <rgarofano@arista.com>
|
Azure Pipelines successfully started running 1 pipeline(s). |
rgarofano-arista
force-pushed
the
change_dummy_ip
branch
from
86bd5e4 to
4cf0832
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @wangxin could you help to review or tag if someone else needs to approve, thanks! |
r12f
approved these changes
Feb 10, 2026
Contributor
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
If the shaper is unable to pause the queue for good, we will have false positive when hitting this.
straightforward change and sign off.
Contributor
|
Needs backport to 202412 and 202511 |
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
…net#22259) What is the motivation for this PR? We were seeing failures in packet trimming tests when verifying UDP packets. This is because the shaper on TH5 is still sending a few packets a second that were used to fill up the buffer (simulating congestion) and these packets are nearly identical to the UDP packets used to verify trimming. This is leading to false positives where a packet that was used to fill the buffer is being detected as a "trimmed" packet when packet trimming is turned off. How did you do it? Fixed this by changing the dummy ip for the packets used to fill the buffer, meaning they won't be mistaken for a packet that the test sends to verify trimming. How did you verify/test it? Verified that the failure goes away with the change. Signed-off-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
sdszhang
added
Request for msft-202412 Branch
Request for 202511 branch
13 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#1025 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 19, 2026
…net#22259) What is the motivation for this PR? We were seeing failures in packet trimming tests when verifying UDP packets. This is because the shaper on TH5 is still sending a few packets a second that were used to fill up the buffer (simulating congestion) and these packets are nearly identical to the UDP packets used to verify trimming. This is leading to false positives where a packet that was used to fill the buffer is being detected as a "trimmed" packet when packet trimming is turned off. How did you do it? Fixed this by changing the dummy ip for the packets used to fill the buffer, meaning they won't be mistaken for a packet that the test sends to verify trimming. How did you verify/test it? Verified that the failure goes away with the change. Signed-off-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Collaborator
|
Cherry-pick PR to 202511: #22474 |
13 tasks
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
…net#22259) What is the motivation for this PR? We were seeing failures in packet trimming tests when verifying UDP packets. This is because the shaper on TH5 is still sending a few packets a second that were used to fill up the buffer (simulating congestion) and these packets are nearly identical to the UDP packets used to verify trimming. This is leading to false positives where a packet that was used to fill the buffer is being detected as a "trimmed" packet when packet trimming is turned off. How did you do it? Fixed this by changing the dummy ip for the packets used to fill the buffer, meaning they won't be mistaken for a packet that the test sends to verify trimming. How did you verify/test it? Verified that the failure goes away with the change. Signed-off-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
mssonicbld
pushed a commit
that referenced
this pull request
Feb 20, 2026
What is the motivation for this PR? We were seeing failures in packet trimming tests when verifying UDP packets. This is because the shaper on TH5 is still sending a few packets a second that were used to fill up the buffer (simulating congestion) and these packets are nearly identical to the UDP packets used to verify trimming. This is leading to false positives where a packet that was used to fill the buffer is being detected as a "trimmed" packet when packet trimming is turned off. How did you do it? Fixed this by changing the dummy ip for the packets used to fill the buffer, meaning they won't be mistaken for a packet that the test sends to verify trimming. How did you verify/test it? Verified that the failure goes away with the change. Signed-off-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
We were seeing failures in packet trimming tests when verifying UDP packets. This is because the shaper on TH5 is still sending a few packets a second that were used to fill up the buffer (simulating congestion) and these packets are nearly identical to the UDP packets used to verify trimming. This is leading to false positives where a packet that was used to fill the buffer is being detected as a "trimmed" packet when packet trimming is turned off.
How did you do it?
Fixed this by changing the dummy ip for the packets used to fill the buffer, meaning they won't be mistaken for a packet that the test sends to verify trimming.
How did you verify/test it?
Verified that the failure goes away with the change.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation