Code owner guidelines

1. Review guidance

• For conditional test markers:

• Do NOT add ‘skip’ label without presenting the justification in test subgroup.
• Recommend using ‘xfail’ label in conjunction with an open issue. So that failure is still on the radar.
• Do NOT add blanket ‘xfail’ without consulting if other platforms are also failing. E.g. if nvidia has an issue with one testcase, please ‘xfail’ it by limiting the platform to nvidia platform(s) (Each vendor should ‘xfail’ on its tested platform(s)).

• Impact-area based PR test enabled testing new test cases with initial PR. Some submitters raise new test cases and a VS test skipper at the same time. These skips need to be scrutinized for a valid reason to skip, e.g. an Ixia is required.
• Enforcing on the commit comment, asking the author to fill in the comments especially (why I did it, how I did it, and how I tested it)
• New test cases should come with a test plan.
• New test cases should NOT be skipped on the vs platform unless there is a legitimate reason.
• New test cases won’t break other platforms to the best level.

2. Merge Guidance -

• Please use squash merge for most cases.
• Please keep the merge comment clean. Suggest copying the PR comments (why I did it, how I did it, how I verified it, etc) to the merge comment.
• Please only merge to master branch. Let the branch manager handle the cherry pick.

3. Repo owner obligations:

• Participate in running community test subgroup meetings in the corresponding timezone.

• Hosting test plan discussions.
• Hosting issue triages.