Make is_flat_memory more robust #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Junchao-Mellanox Can you please modify the below description as well? sonic-platform-common/sonic_platform_base/sonic_xcvr/api/xcvr_api.py Lines 494 to 496 in 7f07fa6 |
keboliu
previously approved these changes
Aug 19, 2024
mihirpat1
approved these changes
Aug 19, 2024
keboliu
approved these changes
Aug 28, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Sep 11, 2024
- Description Currently, is_flat_memory could return 3 different values: True when the module is flat memory False when the module is not flat memory None when the EEPROM read returns None or empty bytearray When it returns None, we should not assume that the module is NOT a flat memory. Instead, it would be safer to treat it as a flat memory. - Motivation and Context This PR is to make is_flat_memory only returns two state, True or False. And if EEPROM reading returns None or empty bytearray, we should treat the module as a flat memory. - How Has This Been Tested? Manual test
|
Cherry-pick PR to 202405: #497 |
mssonicbld
pushed a commit
that referenced
this pull request
Sep 11, 2024
- Description Currently, is_flat_memory could return 3 different values: True when the module is flat memory False when the module is not flat memory None when the EEPROM read returns None or empty bytearray When it returns None, we should not assume that the module is NOT a flat memory. Instead, it would be safer to treat it as a flat memory. - Motivation and Context This PR is to make is_flat_memory only returns two state, True or False. And if EEPROM reading returns None or empty bytearray, we should treat the module as a flat memory. - How Has This Been Tested? Manual test
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
is_flat_memorycould return 3 different values:When it returns None, we should not assume that the module is NOT a flat memory. Instead, it would be safer to treat it as a flat memory.
Motivation and Context
This PR is to make
is_flat_memoryonly returns two state, True or False. And if EEPROM reading returns None or empty bytearray, we should treat the module as a flat memory.How Has This Been Tested?
Manual test
Additional Information (Optional)