Enhanced NVMe disk support, added limited eUSB disk support #493
+313
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ices with NVMe disks
assrinivasan
requested review from
Junchao-Mellanox,
dgsudharsan,
keboliu,
Staphylo,
saiarcot895,
prgeor,
vdahiya12,
mihirpat1 and
vvolam
assrinivasan
changed the title
Merged
3 tasks
|
@Junchao-Mellanox @keboliu could you please review? |
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 19, 2024
Why I did it This module is required in the pmon container for Storage Monitoring Daemon (stormond) to instantiate objects of type (UsbUtil)[sonic-net/sonic-platform-common#493]. Work item tracking Microsoft ADO (number only): 29203991 How I did it Added config to pmon Dockerfile.j2 to install blkinfo How to verify it On an image containing this change, verify following output: root@str2-7050qx-32s-acs-03:/# pip3 list | grep -i blkinfo blkinfo 0.2.0
|
@Staphylo please help review this PR, TIA. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 20, 2024
…-net#20053) Why I did it This module is required in the pmon container for Storage Monitoring Daemon (stormond) to instantiate objects of type (UsbUtil)[sonic-net/sonic-platform-common#493]. Work item tracking Microsoft ADO (number only): 29203991 How I did it Added config to pmon Dockerfile.j2 to install blkinfo How to verify it On an image containing this change, verify following output: root@str2-7050qx-32s-acs-03:/# pip3 list | grep -i blkinfo blkinfo 0.2.0
mssonicbld
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 21, 2024
Why I did it This module is required in the pmon container for Storage Monitoring Daemon (stormond) to instantiate objects of type (UsbUtil)[sonic-net/sonic-platform-common#493]. Work item tracking Microsoft ADO (number only): 29203991 How I did it Added config to pmon Dockerfile.j2 to install blkinfo How to verify it On an image containing this change, verify following output: root@str2-7050qx-32s-acs-03:/# pip3 list | grep -i blkinfo blkinfo 0.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
N/Aafter successfully parsing said values. This is due to an indentation bug and has been fixed as part of this commit.Motivation and Context
This PR is in line with promised future work on the Storage Monitoring Daemon. It adds support for devices with NVMe storage disks.
Needs to be merged only after sonic-net/sonic-buildimage#20053 is merged to master+202405 branches.
How Has This Been Tested?
NVMe
Ran image containing these changes on a device with an NVMe disk and verified that storage disk attributes were getting successfully parsed and updated to
STATE_DB.Syslogs:
STATE_DB:
eUSB
Syslogs:
STATE_DB:
Additional Information (Optional)