Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[action] [PR:491] Make is_flat_memory more robust (#491) #497

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[action] [PR:491] Make is_flat_memory more robust (#491) #497

merged 1 commit into from
Sep 11, 2024

Commits on Sep 11, 2024

  1. Make is_flat_memory more robust (sonic-net#491) 

    - Description
Currently, is_flat_memory could return 3 different values:

True when the module is flat memory
False when the module is not flat memory
None when the EEPROM read returns None or empty bytearray
When it returns None, we should not assume that the module is NOT a flat memory. Instead, it would be safer to treat it as a flat memory.

- Motivation and Context
This PR is to make is_flat_memory only returns two state, True or False. And if EEPROM reading returns None or empty bytearray, we should treat the module as a flat memory.

- How Has This Been Tested?
Manual test
    @Junchao-Mellanox @mssonicbld
    Junchao-Mellanox authored and mssonicbld committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    82dfb06 View commit details
    Browse the repository at this point in the history