Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands#595
Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom Sep 18, 2025
Conversation
…eric health ID for other brands.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @judyjoseph could you help to review? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Skip obtaining vendor SSD info for ATP and Virtium NVMe SSD Add unit test case for ATP NVMe SSD
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Expect conflict on 202412, so a separate PR for it is created: Azure/sonic-platform-common.msft#106 |
|
Hi @markx-arista |
2 tasks
Collaborator
|
Cherry-pick PR to 202505: #598 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
Contributor
Author
Hi, there were failures on our 202412, but we just found out those SSDs are not qualified. So PR to 202412 is not necessary, I will close it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix health check for SSD vendors: add a parser for ATP, and add a generic health ID for other brands.
Each vendor stores health information in different SMART attributes.
ATP stores it in attribute ID 248, we add a parser for it.
We also have SSDs use Attribute ID 231 and it is commonly used, so add it in the generic parser.
Skip obtaining vendor SSD info for ATP and Virtium NVMe SSD because they are handle by parse_generic_ssd_info and parse_vendor_ssd_info will overwrite data with N/A.
Add unit test cases for ATP SATA/NVMe SSD.
Motivation and Context
show platform ssdhealthshows N/A health for some qualified SSDs.Back port request
How Has This Been Tested?
We have tested the code change on DUTs with different SSDs including all the qualified SSDs that show N/A in health and also on the ones that worked fine before.