Check low power mode before vdm handling#653
Merged
prgeor merged 6 commits intosonic-net:masterfrom Aug 29, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
reviewed
Aug 5, 2025
mihirpat1
approved these changes
Aug 5, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mihirpat1
approved these changes
Aug 18, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Aug 29, 2025
Collaborator
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
The module in low power mode can also support VDM but due to the current limitation of the code we don't do separate VDM polling for module vs datapath, this PR for the time being is ok. @mihirpat1 FYI
Contributor
|
@r12f @arlakshm @yejianquan - Can you please help to cherry pick this to 202412, 202503 and 202505? |
Collaborator
|
Cherry-pick PR to 202505: #670 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-platform-daemons.msft#43 |
mssonicbld
added
Included in msft-202503 Branch
and removed
Created PR to msft-202503 Branch
labels
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-platform-daemons.msft#48 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip VDM handling when the interface low power mode is on.
Motivation and Context
When the interface low power mode is on, we see following errors in the syslog:
ERR pmon#xcvrd[76]: Failed to confirm VDM unfreeze status for port 63
ERR pmon#xcvrd[76]: Failed to unfreeze VDM stats in contextmanager for port 63
ERR pmon#xcvrd[76]: Failed to confirm VDM freeze status for port 63
ERR pmon#xcvrd[76]: Failed to freeze VDM stats in contextmanager for port 63
ERR pmon#xcvrd[76]: DOM-INFO-UPDATE: Failed to freeze VDM stats for port 63
ERR pmon#xcvrd[76]: Failed to confirm VDM unfreeze status for port 63
ERR pmon#xcvrd[76]: Failed to unfreeze VDM stats in contextmanager for port 63
To avoid the errors, we are skipping VDM handling when low power mode is on. To achieve this, a helper method is added to check for VDM status which is called before the VDM handling code block.
How Has This Been Tested?
This PR has been tested on 100G OSFP 8X Pluggable Transceiver and 400ZR QSFP-DD Double Density 8X Pluggable Transceiver.
Additional Information (Optional)
ADO: 32013738