Fix dash meter COUNTERS_DB keys to use VID instead of RID#1725
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jan 22, 2026
Merged
Fix dash meter COUNTERS_DB keys to use VID instead of RID#1725prsunny merged 1 commit intosonic-net:masterfrom
prsunny merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prabhataravind and @prsunny : Please can you review and approve this DASH Metering PR |
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
8029e83 to
0ea6a5a
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
0ea6a5a to
6678176
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
6678176 to
78a71c7
Compare
Collaborator
|
/azp run |
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
78a71c7 to
a40332c
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@prabhataravind, can you rerun the sanity. Seems like a random failure |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
suggested changes
Jan 14, 2026
syncd/FlexCounter.cpp
Outdated
| swss::Table countersTable(&pipeline, COUNTERS_TABLE, true); | ||
| for (const auto& object_key: it->second.object_keys) { | ||
| countersTable.del(sai_serialize_meter_bucket_entry(object_key.key.meter_bucket_entry)); | ||
| auto meter_bucket_entry = object_key.key.meter_bucket_entry; |
Contributor
There was a problem hiding this comment.
Same functionality is repeated multiple times. Can we move this to a new method?
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
9641921 to
fa718fe
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
fa718fe to
0b76370
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vivekrnv
approved these changes
Jan 22, 2026
Signed-off-by: mukeshmv <mukesh@pensando.io>
mukeshmv
force-pushed
the
meter_eni_vid
branch
from
0b76370 to
e7257f0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Jan 22, 2026
Collaborator
|
Cherry-pick PR to msft-202506: Azure/sonic-sairedis.msft#103 |
Collaborator
|
Cherry-pick PR to 202511: #1750 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All dash ENI meter class stats were incorrectly written to COUNTERS_DB using the RID instead of the VID as the keys for the switch and ENI oid.
Fix
Use the Switch and ENI VID in the COUNTER_DB keys for dash meter class.