Skip to content

[Mellanox] Add phcsync activation for mellanox platforms.#1734

Merged
tjchadaga merged 5 commits intosonic-net:masterfrom
zili11720:hft_sync_clock
Jan 21, 2026
Merged

[Mellanox] Add phcsync activation for mellanox platforms.#1734
tjchadaga merged 5 commits intosonic-net:masterfrom
zili11720:hft_sync_clock

Conversation

@zili11720
Copy link
Contributor

Activate phcsync script for Mellanox platforms in order to sync the asic clock with the system clock.

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@zili11720 zili11720 changed the title [Mellanox] Add phcsync activation for mellanox platforms. [Mellanox] [202511] Add phcsync activation for mellanox platforms. Jan 5, 2026
@zili11720 zili11720 changed the title [Mellanox] [202511] Add phcsync activation for mellanox platforms. [Mellanox] Add phcsync activation for mellanox platforms. Jan 5, 2026
Signed-off-by: Zili Bombach <zbombach@nvidia.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@r12f @saiarcot895 please help to merge.

Copy link
Contributor

@Pterosaur Pterosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor

Pterosaur commented Jan 18, 2026

Hi @saiarcot895 , can we merge this PR?

The pre-requisite PR: sonic-net/sonic-buildimage#24972

liat-grozovik added a commit to sonic-net/sonic-buildimage that referenced this pull request Jan 19, 2026
- Why I did it
Fix a bug in HFT where the asic clock was not synchronized with the system clock, causing it to report a time around 1970.

There is a dependency between this PR and: sonic-net/sonic-sairedis#1734
The PR to sonic-buildimage should be merged first, followed by the PR to sonic-sairedis.

- How I did it
Added phcsync script for ASIC clock synchronization on Mellanox platforms: created phcsync.sh that syncs PTP clocks with system clock every 60 seconds.

- How to verify it
Which release branch to backport (provide reason below if selected)


Signed-off-by: Zili Bombach <zbombach@nvidia.com>

* Added error logs to phcsync.sh and made phcsync.sh executable

Signed-off-by: Zili Bombach <zbombach@nvidia.com>

---------

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
@liat-grozovik
Copy link
Collaborator

@saiarcot895 @Pterosaur the sonic-buildimage PR is merged. Can you go a head and merge this one please?

@Pterosaur Pterosaur requested a review from saiarcot895 January 19, 2026 21:09
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

SahilChaudhari pushed a commit to SahilChaudhari/sonic-buildimage-sonic-net that referenced this pull request Jan 21, 2026
…et#24972)

- Why I did it
Fix a bug in HFT where the asic clock was not synchronized with the system clock, causing it to report a time around 1970.

There is a dependency between this PR and: sonic-net/sonic-sairedis#1734
The PR to sonic-buildimage should be merged first, followed by the PR to sonic-sairedis.

- How I did it
Added phcsync script for ASIC clock synchronization on Mellanox platforms: created phcsync.sh that syncs PTP clocks with system clock every 60 seconds.

- How to verify it
Which release branch to backport (provide reason below if selected)


Signed-off-by: Zili Bombach <zbombach@nvidia.com>

* Added error logs to phcsync.sh and made phcsync.sh executable

Signed-off-by: Zili Bombach <zbombach@nvidia.com>

---------

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
@tjchadaga tjchadaga merged commit 7632eeb into sonic-net:master Jan 21, 2026
16 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#102

r12f pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Jan 24, 2026
… on mellanox platforms. (#1935)

<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
Fix a bug in HFT where the asic clock was not synchronized with the
system clock, causing it to report a time around 1970.

There is a dependency between this PR and:
sonic-net/sonic-sairedis#1734
The PR to sonic-buildimage should be merged first, followed by the PR to
sonic-sairedis.

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added phcsync script for ASIC clock synchronization on Mellanox
platforms: created phcsync.sh that syncs PTP clocks with system clock
every 60 seconds.

#### How to verify it

<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)

---------

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #1752

spandan-nexthop pushed a commit to spandan-nexthop/sonic-buildimage that referenced this pull request Feb 15, 2026
…et#24972)

- Why I did it
Fix a bug in HFT where the asic clock was not synchronized with the system clock, causing it to report a time around 1970.

There is a dependency between this PR and: sonic-net/sonic-sairedis#1734
The PR to sonic-buildimage should be merged first, followed by the PR to sonic-sairedis.

- How I did it
Added phcsync script for ASIC clock synchronization on Mellanox platforms: created phcsync.sh that syncs PTP clocks with system clock every 60 seconds.

- How to verify it
Which release branch to backport (provide reason below if selected)


Signed-off-by: Zili Bombach <zbombach@nvidia.com>

* Added error logs to phcsync.sh and made phcsync.sh executable

Signed-off-by: Zili Bombach <zbombach@nvidia.com>

---------

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
baorliu pushed a commit to baorliu/sonic-buildimage that referenced this pull request Feb 24, 2026
…et#24972)

- Why I did it
Fix a bug in HFT where the asic clock was not synchronized with the system clock, causing it to report a time around 1970.

There is a dependency between this PR and: sonic-net/sonic-sairedis#1734
The PR to sonic-buildimage should be merged first, followed by the PR to sonic-sairedis.

- How I did it
Added phcsync script for ASIC clock synchronization on Mellanox platforms: created phcsync.sh that syncs PTP clocks with system clock every 60 seconds.

- How to verify it
Which release branch to backport (provide reason below if selected)


Signed-off-by: Zili Bombach <zbombach@nvidia.com>

* Added error logs to phcsync.sh and made phcsync.sh executable

Signed-off-by: Zili Bombach <zbombach@nvidia.com>

---------

Signed-off-by: Zili Bombach <zbombach@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants