Fix switch stat counters by using get_stats_ext instead of get_stats#1757
Merged
tjchadaga merged 1 commit intosonic-net:masterfrom Feb 10, 2026
Merged
Conversation
Signed-off-by: Ryan Garofano <rgarofano@arista.com>
rgarofano-arista
force-pushed
the
fix-switch-stat-counters
branch
from
33b8944 to
b175979
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 1757 in repo sonic-net/sonic-sairedis |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
hi @nazariig , do you mind to help check this PR? |
Collaborator
|
@r12f are we good to kick off? |
r12f
approved these changes
Feb 10, 2026
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#105 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
vivekrnv
pushed a commit
to vivekrnv/sonic-sairedis
that referenced
this pull request
Feb 18, 2026
…#1757) Signed-off-by: Ryan Garofano <rgarofano@arista.com> Signed-off-by: Vivek Reddy <vkarri@nvidia.com>
Merged
2 tasks
Collaborator
|
Cherry-pick PR to 202511: #1775 |
Collaborator
|
@rgarofano-arista cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@rgarofano-arista cherry pick PR didn't pass PR checker. Please check!!! |
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were seeing N/A for switch trimming counters in sonic-mgmt testing with th5. It turns out Broadcom only supports get_stats_ext in their SAI implementation. This PR switches from using get_stats to get_stats_ext to retrieve counters that are object type switch. This PR may be breaking to other vendors if they need to use get_stats.
Backport Request