Ignore nonexistent include in database_global.json

[yue-fred-gao]

why

SonicDBConfig::initializeGlobalConfig aborts parsing global config if it encounters an include of a database config that doesn't exist. The global config file includes all possible includes in the switch. However, not all includes are relevant to a client. For example, in smartswitch, dash-ha container only cares NPU databases and databases of the DPU managed by the container. The current behavior requires a dash-ha container mounting all the DPU database instances.

what this PR does

1. Add ignore_nonexistent flag, with default value false, to function parseDatabaseConfig. If it is set to true, it will not throw error if the included database config file doesn't exist.
2. initializeGlobalConfig sets ignore_nonexistent to true when calling parseDatabaseConfig. If inst_entry, db_entry and separator_entry are empty, it will ignore the key.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yue-fred-gao]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yue-fred-gao]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yue-fred-gao]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yue-fred-gao]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[yue-fred-gao]

hi @liuh-80 , is anybody investigating the test failure in PerformancetimerTest.basic?

tests/performancetimer_ut.cpp:42: Failure
Expected equality of these values:
  output
    Which is: "{\"API\":\"basic_set_name\",\"RPS[k]\":4.9,\"Tasks\":3000,\"Total[ms]\":607,\"busy[ms]\":400,\"idle[ms]\":207,\"m_gaps\":[7,200],\"m_incs\":[1000,2000],\"m_intervals\":[100,300]}"
  expected
    Which is: "{\"API\":\"basic_set_name\",\"RPS[k]\":5.0,\"Tasks\":3000,\"Total[ms]\":600,\"busy[ms]\":400,\"idle[ms]\":200,\"m_gaps\":[0,200],\"m_incs\":[1000,2000],\"m_intervals\":[100,300]}"
[  FAILED  ] PerformancetimerTest.basic (708 ms)

[mssonicbld]

/azp run

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qiluo-msft]

sonic_db_config_initialize_global

This will break existing Rust application using this function. Since Rust does not support default parameter value like Python/C++, does not support function overloading. There are 2 options:

1. keep original function unchanged, and add anotehr function like sonic_db_config_initialize_global_ignore_nonexistent usiing more parameters.
2. treat it as breaking change, and update all the Rust applications.

[yue-fred-gao]

hi @qiluo-msft, I plan to commit the change in dash-ha at the same time. When we update sonic-buildimage, it needs to go in at the same time as this. Are there other rust applications using this function? If there is and hard to coordinate, I can implement 1 to break the dependency.

[qiluo-msft]

As far as I know, only dash-ha is using it.

[Pterosaur]

As far as I know, only dash-ha is using it.

Hi @qiluo-msft , I'm using this rest API as well in the swss.
sonic-net/sonic-swss#3796

[yue-fred-gao]

@Pterosaur , is it in the committed code that needs to be updated at the same time?

[mssonicbld]

Cherry-pick PR to msft-202506: Azure/sonic-swss-common.msft#53

[mssonicbld]

Cherry-pick PR to msft-202412: Azure/sonic-swss-common.msft#64