Skip to content

Comments

Fix mocktests for buster builds#1087

Merged
prabhataravind merged 1 commit intosonic-net:masterfrom
prabhataravind:fix_mocktests
Oct 10, 2025
Merged

Fix mocktests for buster builds#1087
prabhataravind merged 1 commit intosonic-net:masterfrom
prabhataravind:fix_mocktests

Conversation

@prabhataravind
Copy link
Contributor

@prabhataravind prabhataravind commented Oct 10, 2025

   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1

 * PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_.
   This changes fixes the error below

    ```
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token
 INSTANTIATE_TEST_SUITE_P(
                         ^
tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1

    ```

Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@prabhataravind prabhataravind marked this pull request as ready for review October 10, 2025 19:16
@prabhataravind
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202506: Azure/sonic-swss-common.msft#69

jasper-hou-micas pushed a commit to jasper-hou-micas/sonic-swss-common that referenced this pull request Jan 22, 2026
* PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_.
   This changes fixes the error below

    ```
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token
 INSTANTIATE_TEST_SUITE_P(
                         ^
tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1

    ```

Signed-off-by: Prabhat Aravind <paravind@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants